FileSystemEntry.Unix: ensure properties are available when file is deleted.

[tmds]

When the file no longer exists, we create attributes based on what we know.

The test for this was passing because it cached the attributes before the
item was deleted due to enumerating with skipping FileAttributes.Hidden.

@carlossanlop ptal.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

---

When the file no longer exists, we create attributes based on what we know.

The test for this was passing because it cached the attributes before the
item was deleted due to enumerating with skipping FileAttributes.Hidden.

@carlossanlop ptal.

Author:	tmds
Assignees:	-
Labels:	area-System.IO, community-contribution
Milestone:	-

[tmds]

I'll extend the tests so it covers more of the changes.

[tmds]

This is up for review.

[tmds]

@carlossanlop ptal. This fixes a bug in how FileSystemEntry behaves when the underlying entry was deleted. There is a test for this, but it inadvertently captured the properties up-front due to the default EnumerationOptions checking to skip FileAttributes.Hidden. I've extended the test.

[tmds]

@dotnet/area-system-io @stephentoub ptal.

[tmds]

@jeffhandley@carlossanlop@jozkee@adamsitnik can you make some time to review the PRs I've created for System.IO: https://github.com/dotnet/runtime/pulls?q=is%3Aopen+is%3Apr+author%3Atmds+label%3Aarea-System.IO.

[adamsitnik]

Overall LGTM, but it would be great if @carlossanlop or @jozkee could review the FileSystemEntry changes.

[tmds]

I'll look at addressing the feedback tomorrow.

[carlossanlop]

LGTM so far, only 3 things left to address:

• Remove the AssertExtensions.EqualsTo code.
• Please open an issue to describe the two bugs being fixed by this PR.
• In particular, the second bug, which you mentioned in a comment in line 333 of FileStatus.Unix.cs, I'm not sure how you caught that, or if it needs a unit test to verify the change worked. Would you mind elaborating? Normally we expect to have an issue open first, where the bug is described and discussed.

Thanks for sending the PR, and apologies for the delay.

[tmds]

@carlossanlop I've created #61764 to described the issues that are fixed by this PR.

[adamsitnik]

LGTM, thank you @tmds!

[tmds]

Thanks for the review @adamsitnik and @carlossanlop!