Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Fallback to read/write if pread/pwrite fails - #60280
Merged
Conversation
…/pwrite for unseekable files * Fallback to read/write only for known error ENXIO
…esAndSockets.cs Use Lazy for thread-safety Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
ghost
commented
Oct 12, 2021
Tagging subscribers to this area: @dotnet/area-system-io |
jeffhandley
approved these changes
Oct 12, 2021
jeffhandley
left a comment
Member
There was a problem hiding this comment.
I'm sending to tactics for consideration.
adamsitnik
approved these changes
Oct 12, 2021
jeffhandley
commented
Oct 12, 2021
Member
Tactics approved for 6.0 GA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59846 to release/6.0.
Fixes#59754
Customer Impact
On Unix, Read/Write to certain special devices e.g:
/dev/ttyusing FIleStream stopped working on 6.0 given that we now use a different syscall for unseekable files.Our assumption was that such files always reported
CanSeekas false, but that turned out to not be true for/dev/ttyon macOS.This change catches the aforementioned error and fallbacks to the syscall that we previously used for seekable and non-seekable files.
Testing
Tested with many other devices that share similarities with
/dev/tty:e.g:
/dev/null,/dev/zero,/dev/console, named pipes and socket pairs.Risk
Low, we are affecting one edge case only which currently is in a regression state.