[release/6.0] Stabilize for RTM by mmitche · Pull Request #60294 · dotnet/runtime

mmitche · 2021-10-12T15:17:00Z

No description provided.

ghost · 2021-10-12T15:17:08Z

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	mmitche
Assignees:	-
Labels:	`area-Infrastructure-libraries`
Milestone:	-

ViktorHofer · 2021-10-12T16:06:42Z

D:\a_work\1\s.dotnet\sdk\6.0.100-rc.1.21430.12\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "xunit.assert [2.4.2-pre.9, )" or update the version field in the nuspec. [D:\a_work\1\s\src\libraries\Microsoft.Extensions.DependencyInjection.Specification.Tests\src\Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj]
##[error].dotnet\sdk\6.0.100-rc.1.21430.12\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: (NETCORE_ENGINEERING_TELEMETRY=Build) A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "xunit.assert [2.4.2-pre.9, )" or update the version field in the nuspec.

It's probably easiest to just downgrade this product dependency to the latest stable release of xunit: 2.4.1 in src\libraries\Microsoft.Extensions.DependencyInjection.Specification.Tests\src\Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj.

ViktorHofer · 2021-10-12T16:09:40Z

/__w/1/s/src/libraries/workloads-testing.targets(95,5): error : Could not find cross compiler nupkg at /__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm.6.0.0-ci.nupkg. Found packages: /__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.MonoAOTCompiler.Task.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.MonoTargets.Sdk.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.wasm.Sample.Mono.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.WebAssembly.Sdk.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Workload.Mono.ToolChain.Manifest-6.0.100.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm.6.0.0.symbols.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.Mono.browser-wasm.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.Mono.browser-wasm.6.0.0.symbols.nupkg [/__w/1/s/src/tests/BuildWasmApps/Wasm.Build.Tests/Wasm.Build.Tests.csproj]

@steveisok who would be the best person to look into this error? @Anipik any idea why this didn't show up during the servicing readiness exercise?

mmitche · 2021-10-12T16:14:41Z

/__w/1/s/src/libraries/workloads-testing.targets(95,5): error : Could not find cross compiler nupkg at /__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm.6.0.0-ci.nupkg. Found packages: /__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.MonoAOTCompiler.Task.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.MonoTargets.Sdk.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.wasm.Sample.Mono.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.WebAssembly.Sdk.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Workload.Mono.ToolChain.Manifest-6.0.100.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm.6.0.0.symbols.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.Mono.browser-wasm.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.Mono.browser-wasm.6.0.0.symbols.nupkg [/__w/1/s/src/tests/BuildWasmApps/Wasm.Build.Tests/Wasm.Build.Tests.csproj]
@steveisok who would be the best person to look into this error? @Anipik any idea why this didn't show up during the servicing readiness exercise?

Possibilities:

This didn't get built in the official build.
Something changed.

Anyways, why is a test package stabilizing? @Anipik did all the stabilization fixes make it into release/6.0?

mmitche · 2021-10-12T17:25:19Z

Hold till 10/18

ghost · 2021-10-12T17:32:35Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	mmitche
Assignees:	-
Labels:	`* NO MERGE *`, `area-Infrastructure`
Milestone:	-

Anipik · 2021-10-12T19:37:22Z

Microsoft.Extensions.DependencyInjection.Specification.Tests shipping test package. we didnt hit this in servicing readiness because we just updated the xunit package.
cc @maryamariyan @ericstj

radical · 2021-10-12T19:49:01Z

The version string is being used in the following places for wasm/workload testing:

The logs show that for all the 3 cases, the version string being used is 6.0.0-ci, but IIUC, it should be 6.0.0. Are we using the wrong property?

The current failure is being caused (2).

Anipik · 2021-10-12T20:08:01Z

i will take a look at the workloads failures

ericstj · 2021-10-12T20:36:38Z

We should change these

runtime/src/libraries/Microsoft.Extensions.DependencyInjection.Specification.Tests/src/Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj

Lines 15 to 16 in e734fde

 <PackageReferenceInclude="xunit.assert"Version="$(XUnitVersion)" /> 
 <PackageReferenceInclude="xunit.extensibility.core"Version="$(XUnitVersion)" /> 

Back to 2.4.1.

mmitche · 2021-10-15T15:27:03Z

@Anipik We need to get this in first thing Monday morning, can it be green by EOD?

Anipik · 2021-10-15T16:55:47Z

@Anipik We need to get this in first thing Monday morning, can it be green by EOD?

we need a stable dependency update from the wcf repo, that should fix the service model error

… test

Anipik · 2021-10-18T07:00:15Z

#60482

example green pr with no after reverting back to the wcf version. (i have ported most of it so we should be good after wcf update)

Created an issue for the failing test. It doesnt look like a blocking issue. #60532 i have tagged some folks there to verify it.

mmitche · 2021-10-18T17:58:41Z

@safern We'll need the wcf build published and an input nuget feed for it. Build is currently ongoing.

mmitche · 2021-10-18T19:04:17Z

Updated dependencies to stable versions.

Stabilize for RTM
4d495d4

ghost added the area-Infrastructure-libraries label Oct 12, 2021

mmitche requested a review from Anipik October 12, 2021 15:17

ViktorHofer added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-Infrastructure and removed area-Infrastructure-libraries labels Oct 12, 2021

ViktorHofer added this to the 6.0.0 milestone Oct 12, 2021

Anipik approved these changes Oct 12, 2021
View reviewed changes

hoyosjs approved these changes Oct 12, 2021
View reviewed changes

Anipik force-pushed the stabilize branch from 8f8844a to 7f9c6cfCompare October 12, 2021 21:25

mmitche requested a review from marek-safar as a code owner October 12, 2021 21:45

ViktorHofer reviewed Oct 15, 2021
View reviewed changes

Comment threadsrc/mono/Directory.Build.props Outdated

revert xunit version to fix MEDIspecificationTests package
9a1afe6

Anipik force-pushed the stabilize branch from 01a6eaf to 031537cCompare October 18, 2021 05:06

pass the correct wasm package version and disable the coreclr failing…
a2d45fb
… test

Anipik force-pushed the stabilize branch from 031537c to a2d45fbCompare October 18, 2021 06:45

Update wcf and system.data.sqlclient compat pack dependencies
cae8bed

Anipik removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 18, 2021

runfoappBot mentioned this pull request Oct 18, 2021
Error in CI Mono llvmfullaot Pri0 Runtime Tests Run Linux arm64 release#60234
Closed

safern closed this Oct 18, 2021

safern reopened this Oct 18, 2021

Update WCF dependencies
85dfe25

mmitche merged commit ba7a7bb into dotnet:release/6.0Oct 19, 2021

ghost locked as resolved and limited conversation to collaborators Nov 18, 2021

Uh oh!

Conversation

mmitche commented Oct 12, 2021

Uh oh!

ghost commented Oct 12, 2021

Uh oh!

ViktorHofer commented Oct 12, 2021

Uh oh!

ViktorHofer commented Oct 12, 2021

Uh oh!

mmitche commented Oct 12, 2021

Uh oh!

mmitche commented Oct 12, 2021

Uh oh!

ghost commented Oct 12, 2021

Uh oh!

Anipik commented Oct 12, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

radical commented Oct 12, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anipik commented Oct 12, 2021

Uh oh!

ericstj commented Oct 12, 2021

Uh oh!

mmitche commented Oct 15, 2021

Uh oh!

Uh oh!

Anipik commented Oct 15, 2021

Uh oh!

Anipik commented Oct 18, 2021

Uh oh!

mmitche commented Oct 18, 2021

Uh oh!

mmitche commented Oct 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Anipik commented Oct 12, 2021•
edited
Loading

radical commented Oct 12, 2021•
edited
Loading