Skip to content

[release/6.0] [mono/win] Increase stack size (reserve) to 8MB - #60561

Merged
Anipik merged 1 commit into
release/6.0from
backport/pr-60265-to-release/6.0
Nov 9, 2021
Merged

[release/6.0] [mono/win] Increase stack size (reserve) to 8MB#60561
Anipik merged 1 commit into
release/6.0from
backport/pr-60265-to-release/6.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

Backport of #60265 to release/6.0

/cc @lewing@radekdoulik

Increase the AOT compilers reserve stack size to 8MB to avoid an AOT compilation failure due to insufficient stack space.

Customer Impact

Resolves a potential crash in AOT compilation.

Testing

Manual and Automatic

Risk

Very Low

Fix#57141 in windows build.
Set the stack size (reserve) to 8MB, which is usually a default
on linux. This way we should get similar behavior on windows.
@Anipik

Copy link
Copy Markdown
Contributor

cc @marek-safar

@lewinglewing added this to the 6.0.1 milestone Oct 21, 2021
@marek-safarmarek-safar added the Servicing-consider Issue for next servicing release review label Oct 22, 2021
@jacob-l

Copy link
Copy Markdown

I tested this PR, and it solves the issue; we can compile projects successfully. Thanks!

@leecowleecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 2, 2021
@Anipik
Anipik merged commit f9c4b56 into release/6.0Nov 9, 2021
@jkotas
jkotas deleted the backport/pr-60265-to-release/6.0 branch November 13, 2021 22:59
@ghostghost locked as resolved and limited conversation to collaborators Dec 14, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Codegen-AOT-monoServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Anipik@jacob-l@lewing@marek-safar@leecow@radekdoulik