Skip to content

Fix GCC warnings in test build - #60734

Merged
davmason merged 3 commits into
dotnet:mainfrom
davmason:gcc_warning
Oct 22, 2021
Merged

Fix GCC warnings in test build#60734
davmason merged 3 commits into
dotnet:mainfrom
davmason:gcc_warning

Conversation

@davmason

@davmasondavmason commented Oct 21, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@davmasondavmason self-assigned this Oct 21, 2021
@ghost

ghost commented Oct 21, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:davmason
Assignees:davmason
Labels:

area-Diagnostics-coreclr

Milestone:-

@davmason

davmason commented Oct 21, 2021

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr GCC Product Build Linux x64 checked

@azure-pipelines

azure-pipelinesBot commented Oct 21, 2021

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@davmason

davmason commented Oct 21, 2021

Copy link
Copy Markdown
ContributorAuthor

@hoyosjs or @am11, how do I trigger the failing GCC leg on this PR?

@am11

am11 commented Oct 21, 2021•
edited
Loading

Copy link
Copy Markdown
Member

You can cherry-pick my commit from #60738. cc @safern
(or make a whitespace change under src/coreclr as a workaround)

am11
am11 reviewed Oct 21, 2021
View reviewed changes

@am11am11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc leg is green here, I'll go ahead and close #60738. Thanks. 👍

@am11am11 mentioned this pull request Oct 21, 2021
Closed
@davmason

davmason commented Oct 21, 2021

Copy link
Copy Markdown
ContributorAuthor

Adding infrastructure people since the infra changes are over here now

BruceForstall
BruceForstall approved these changes Oct 21, 2021
View reviewed changes

@BruceForstallBruceForstall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runfoapprunfoappBot mentioned this pull request Oct 21, 2021
Open
safern
safern approved these changes Oct 22, 2021
View reviewed changes

@safernsafern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davmason

davmason commented Oct 22, 2021

Copy link
Copy Markdown
ContributorAuthor

I don't see how the failing libraries leg can be related, since this is fixing another failing leg I'm going to merge now

@davmason
davmason merged commit 565f3ee into dotnet:mainOct 22, 2021
@ghostghost locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@hoyosjshoyosjshoyosjs approved these changes
@safernsafernsafern approved these changes
+2 more reviewers
@am11am11am11 left review comments
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@davmasondavmason

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@davmason@am11@jkoritzinsky@BruceForstall@hoyosjs@safern