Throwing `FormatException` when a required property from `Microsoft.Extensions.DependencyModel` is empy by filipjelic · Pull Request #60842 · dotnet/runtime

filipjelic · 2021-10-25T20:39:41Z

Throwing FormatException when a required property is null/empty.
This enables removal of all ! operations addressed in #58139 (comment)

…e as nullable (string) properties.

ghost · 2021-10-25T20:39:49Z

Tagging subscribers to this area: @eerhardt
See info in area-owners.md if you want to be subscribed.

Issue Details

Updating property types (strings) to be nullable for:

class Target property Name
class TargetLibrary property Name
class RuntimeTargetEntryStub property Path

This enables removal of all ! operations addressed in #58139 (comment)

Author:	filipjelic
Assignees:	-
Labels:	`area-DependencyModel`, `community-contribution`
Milestone:	-

dnfadmin · 2021-10-25T20:39:56Z

All CLA requirements met.

filipjelic · 2021-10-27T07:42:07Z

@eerhardt Ready for review.

…pty values. Adding unit tests to check for specific null/empty value cases

eerhardt

Looks like a good start, @filipjelic. Thanks.

I have left some comments.

Updating PR according to comments

filipjelic · 2021-10-28T16:04:34Z

@eerhardt Code and unit tests have been updated accordingly.
Thanks!

eerhardt

Looking good. Just a few last comments to fix up.

…ncyContextJsonReader.cs

eerhardt

LGTM. Thanks for the contribution @filipjelic!

filipjelic added 5 commits October 25, 2021 22:30

Setting framework name as nullable.
6646df9

Setting path to nullable.
bf0adc0

Setting runtime to nullable.
7a7c260

Setting path to nullable.
e3c9d35

Setting Target Name, RuntimeTargetEntrySub Path and TargetLibrary Nam…
ef7fd3c
…e as nullable (string) properties.

ghost added area-DependencyModel community-contribution Indicates that the PR has been added by a community member labels Oct 25, 2021

filipjelic marked this pull request as draft October 25, 2021 23:57

Adding missing line of code.
834881c

filipjelic marked this pull request as ready for review October 26, 2021 00:19

filipjelic changed the title ~~Setting nullable properties and removing null forgiving operator from Microsoft.Extensions.DependencyModel~~Setting nullable string properties from Microsoft.Extensions.DependencyModelOct 26, 2021

Merge branch 'main' into SettingNullableTargetName
96febc3

runfoappBot mentioned this pull request Oct 26, 2021
1ES Pools often run out of space #60610
Closed

filipjelic mentioned this pull request Oct 27, 2021
Remove ! from Microsoft.Extensions.DependencyModel#58139
Closed

filipjelic added 2 commits October 28, 2021 01:51

Adding new string resource and throwing argument exception on null/em…
3560d0d
…pty values. Adding unit tests to check for specific null/empty value cases

Merge branch 'main' into SettingNullableTargetName
629b2c1

eerhardt reviewed Oct 28, 2021
View reviewed changes

runfoappBot mentioned this pull request Oct 28, 2021
System.Net.Sockets.Tests.SendPacketsAsync.SendPacketsElement_FileZeroCount_Success sometimes fails #60017
Closed

filipjelic added 6 commits October 28, 2021 17:43

Removing Argument from string resource.
1871188
Updating PR according to comments

Updating unit tests to use FormatException
ef74b15

Rollback of ArgumentExceptions in DependencyModels
10338cb

Added missing usings
83a32ab

Updating all exceptions to FormatException
459ae57

Moving FormatException while reading target name
acec1f6

filipjelic requested a review from eerhardt October 28, 2021 17:32

eerhardt reviewed Oct 28, 2021
View reviewed changes

Updating PR with new comments.
edfdd6d

filipjelic commented Oct 28, 2021
View reviewed changes

Comment threadsrc/libraries/Microsoft.Extensions.DependencyModel/src/DependencyContextJsonReader.cs Outdated

Update src/libraries/Microsoft.Extensions.DependencyModel/src/Depende…
457530c
…ncyContextJsonReader.cs

filipjelic requested a review from eerhardt October 29, 2021 00:10

eerhardt approved these changes Oct 29, 2021
View reviewed changes

runfoappBot mentioned this pull request Oct 29, 2021
CopyToNanosecondsPresent_LowTempRes #48717
Closed

filipjelic changed the title ~~Setting nullable string properties from Microsoft.Extensions.DependencyModel~~Throwing FormatException when a required property from Microsoft.Extensions.DependencyModel is empyOct 30, 2021

filipjelic changed the title ~~Throwing FormatException when a required property from Microsoft.Extensions.DependencyModel is empy~~Throwing FormatException when a required property from Microsoft.Extensions.DependencyModel is empyOct 30, 2021

Merge branch 'main' into SettingNullableTargetName
cbc2321

eerhardt merged commit a3f31e9 into dotnet:mainNov 2, 2021

filipjelic deleted the SettingNullableTargetName branch November 2, 2021 19:38

ghost locked as resolved and limited conversation to collaborators Dec 10, 2021

Uh oh!

Conversation

filipjelic commented Oct 25, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 25, 2021

Uh oh!

dnfadmin commented Oct 25, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filipjelic commented Oct 27, 2021

Uh oh!

eerhardt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

filipjelic commented Oct 28, 2021

Uh oh!

eerhardt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eerhardt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

filipjelic commented Oct 25, 2021•
edited
Loading

dnfadmin commented Oct 25, 2021•
edited
Loading