Skip to content

Extract various changes from the invoke and custom marshaler PRs - #60877

Merged
kg merged 7 commits into
dotnet:mainfrom
kg:extract-bindings-changes
Oct 28, 2021
Merged

Extract various changes from the invoke and custom marshaler PRs#60877
kg merged 7 commits into
dotnet:mainfrom
kg:extract-bindings-changes

Conversation

@kg

@kgkg commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

As requested by @pavelsavara , this extracts some useful changes from #47640 and #60765 so we can land them separately.

@ghost

ghost commented Oct 26, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@kgkg added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) arch-wasm WebAssembly architecture labels Oct 26, 2021
@kg
kg requested a review from pavelsavaraOctober 26, 2021 17:47
@ghost

ghost commented Oct 26, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

As requested by @pavelsavara , this extracts some useful changes from #47640 and #60765 so we can land them separately.

Author:kg
Assignees:-
Labels:

* NO MERGE *, arch-wasm

Milestone:-

@kg
kg requested a review from lewingOctober 26, 2021 17:47
This was referenced Oct 26, 2021
Closed
Closed
pavelsavara
pavelsavara reviewed Oct 26, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/class-loader.ts Outdated
pavelsavara
pavelsavara reviewed Oct 26, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c Outdated
pavelsavara
pavelsavara reviewed Oct 26, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c Outdated
pavelsavara
pavelsavara reviewed Oct 26, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/method-binding.ts Outdated
pavelsavara
pavelsavara reviewed Oct 26, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/method-calls.ts Outdated
pavelsavara
pavelsavara reviewed Oct 26, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/roots.ts Outdated
pavelsavara
pavelsavara reviewed Oct 27, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/method-calls.ts Outdated
@runfoapprunfoappBot mentioned this pull request Oct 27, 2021
Closed
@kg
kg marked this pull request as ready for review October 28, 2021 10:31
@kg
kg requested a review from marek-safar as a code ownerOctober 28, 2021 10:31
@kgkg removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 28, 2021
@kg
kg merged commit 1b423c3 into dotnet:mainOct 28, 2021
@ghostghost locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecture

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kg@pavelsavara