Uh oh!
There was an error while loading. Please reload this page.
[mono][interp] Fix GetType called on ptr constrained to Nullable` - #61020
Merged
Conversation
ghost
commented
Oct 29, 2021
Tagging subscribers to this area: @BrzVlad Issue DetailsWe were statically optimizing this call to return the actual constrained class type, which is incorrect for nullables, because boxing of a nullable (as part of the constrained call) actually creates an object with the type of the nullable's value (or null if there is no value). Fixes #61007
|
vargaz
approved these changes
Oct 29, 2021
lewing
commented
Oct 29, 2021
Member
/backport to release/6.0 |
Contributor
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1400673059 |
radical
commented
Oct 30, 2021
Member
This needs a test. |
BrzVlad
commented
Oct 30, 2021
MemberAuthor
@radical Any recommendation where ? In the runtime tests ? |
radical
commented
Oct 31, 2021
Member
Adding in runtime tests makes sense. |
We were statically optimizing this call to return the actual constrained class type, which is incorrect for nullables, because boxing of a nullable (as part of the constrained call) actually creates an object with the type of the nullable's value (or null if there is no value).
BrzVladforce-pushed
the
fix-interp-nullable-gettype
branch
from
November 1, 2021 11:14
0e9493b to
989f46dCompareBrzVlad
commented
Nov 1, 2021
MemberAuthor
|
BrzVladforce-pushed
the
fix-interp-nullable-gettype
branch
from
November 1, 2021 13:30
989f46d to
92ee613Comparelambdageek
approved these changes
Nov 1, 2021
lewing
commented
Nov 2, 2021
Member
/backport to release/6.0 |
Contributor
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1413414901 |
BrzVlad added a commit
to BrzVlad/runtime
that referenced
this pull request
Nov 8, 2021
…tnet#61020) * [interp] Fix GetType called on ptr constrained to Nullable` We were statically optimizing this call to return the actual constrained class type, which is incorrect for nullables, because boxing of a nullable (as part of the constrained call) actually creates an object with the type of the nullable's value (or null if there is no value). * Add test for GetType call on ptr constrained to nullable
1 task
Anipik pushed a commit
that referenced
this pull request
Nov 12, 2021
…1020) (#61305) * [interp] Fix GetType called on ptr constrained to Nullable` We were statically optimizing this call to return the actual constrained class type, which is incorrect for nullables, because boxing of a nullable (as part of the constrained call) actually creates an object with the type of the nullable's value (or null if there is no value). * Add test for GetType call on ptr constrained to nullable
This was referenced Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were statically optimizing this call to return the actual constrained class type, which is incorrect for nullables, because boxing of a nullable (as part of the constrained call) actually creates an object with the type of the nullable's value (or null if there is no value).
Fixes#61007