Uh oh!
There was an error while loading. Please reload this page.
[release/6.0.1] add support for macOS 12 - #61028
Conversation
* fix rid processing on macOS * Update src/native/corehost/hostmisc/pal.unix.cpp * Update src/native/corehost/hostmisc/pal.unix.cpp * remove extra size calculation
The `else if (major == 12)` is dead code, since the previous if `if (major > 11)` would be true for `major == 12`. Judging by the comment and code, it looks like the intention of this `else if` statement was to match `major == 11`.
ghost
commented
Oct 30, 2021
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsCustomer ImpactmacOS 12.0 Monterey was released this week, support for it missed the 6.0 release train. TestingI mentally verified that `dotnet --info' returns expect value. (e.g. does not fall-back to basic osx-x64) Regressionno. new OS support. Risksmall. Should not impact other platform. 5.x and 3.1 will need separate changes.
|
wfurt
commented
Oct 30, 2021
BTW I'm not sure if we need usual packaging changes for platform @Anipik and how that fits with current 6.0 process. For now, I did not put them in. |
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. We should take for consideration in 6.0.x
Anipik
commented
Nov 4, 2021
We will need to add the packaging changes here. here are the guidelines https://github.com/dotnet/runtime/blob/release/6.0/docs/project/library-servicing.md |
Anipik
commented
Nov 9, 2021
@wfurt can you add the packaging changes here ? |
wfurt
commented
Nov 9, 2021
Thanks @Anipik for the update. I'm swamped with servicing and I did not find time to work on this again. |
Anipik
commented
Nov 10, 2021
welcome :) |
Customer Impact
macOS 12.0 Monterey was released this week, support for it missed the 6.0 release train.
without RID and fixes to determine OS version packaging may not work correctly.
Testing
I mentally verified that `dotnet --info' returns expect value. (e.g. does not fall-back to basic osx-x64)
Regression
no. new OS support.
Risk
small. Should not impact other platform. 5.x and 3.1 will need separate changes.