Uh oh!
There was an error while loading. Please reload this page.
Some VN refactoring - #61034
Merged
jakobbotsch merged 5 commits intoNov 2, 2021
Merged
Conversation
ghost
commented
Oct 30, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIn my VN work, I've always found myself making small changes that improve the code in some minor way. Because the substantive changes to come must be focused solely on the functional parts, I've collected all the refactoring pieces in this PR. No diffs for this change per SPMI, as expected.
|
It was unused and all the callers passed the current block anyway. Also some renaming to make Assign and AssignTypeCoerce methods consistent.
By naming parameters properly.
By naming parameters properly.
In my upcoming substantive changes to this code the unreasonable level of nesting started to significantly degrade the readability of code. So, move it out of the main numbering function. The result is still pretty huge and could be split up further, but this will do for now.
Make it use a loop instead of recursion. Rename parameters to match the "Assign" variants. Add standard header comments.
SingleAccretionforce-pushed
the
Improve-Handling-Of-Type-Mismatch-In-VN-Detour
branch
from
October 30, 2021 13:22
19da386 to
cc7838dCompareSingleAccretion
marked this pull request as ready for review
October 30, 2021 15:34
SingleAccretion
commented
Oct 30, 2021
ContributorAuthor
@dotnet/jit-contrib |
JulieLeeMSFT
commented
Nov 1, 2021
Member
@jakobbotsch PTAL. |
SingleAccretion
deleted the
Improve-Handling-Of-Type-Mismatch-In-VN-Detour
branch
November 2, 2021 17:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my VN work, I've always found myself making small changes that improve the code in some minor way. Because the substantive changes to come must be focused solely on the functional parts, I've collected all the refactoring pieces in this PR.
No diffs for this change per SPMI, as expected.
Part of #58312.