Uh oh!
There was an error while loading. Please reload this page.
Adding support for X86Base.Pause() and ArmBase.Yield() - #61065
Conversation
ghost
commented
Nov 1, 2021
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
commented
Nov 1, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis resolves #53532
|
There was a problem hiding this comment.
it's 14x lower on pre-Skylakes. It reminds me this issue #8744
There was a problem hiding this comment.
Yes, but all of our latencies are currently dependent on and configured for Skylake.
We'd need some more advanced setup if we wanted to track per architecture latencies/throughput.
Uh oh!
There was an error while loading. Please reload this page.
echesakov
left a comment
There was a problem hiding this comment.
I assume this is no-diff change?
tannergooding
commented
Nov 11, 2021
Correct, although it looks like there is some minor issue on Arm64 I might need to fix still. |
tannergooding
commented
Nov 15, 2021
@echesakovMSFT, could you take a quick peak at the one additional commit that resolves the ARM64 issue. It's now generating the correct code and working as expected. The issue was that the category wasn't being handled correctly and a few tweaks were needed to handle there being no args, no base type, and no EA_ATTR. |
This resolves#53532