Skip to content

Add Maui iOS and MacCatalyst build steps - #61068

Merged
LoopedBard3 merged 7 commits into
dotnet:mainfrom
LoopedBard3:MauiiOSTestingClean
Nov 2, 2021
Merged

Add Maui iOS and MacCatalyst build steps#61068
LoopedBard3 merged 7 commits into
dotnet:mainfrom
LoopedBard3:MauiiOSTestingClean

Conversation

@LoopedBard3

@LoopedBard3LoopedBard3 commented Nov 1, 2021

Copy link
Copy Markdown
Member

Added the Maui iOS and MacCatalyst build steps for the SOD performance testing (per dotnet/performance#2075). Includes addition of runtime replacement during build, building of necessary runtime files, building of iOS and MacCatalyst, piping of the built apps through the pipeline, and the helix items for the tests.

@ghostghost added the area-Infrastructure-coreclr Only use for closed issues label Nov 1, 2021
@ghost

ghost commented Nov 1, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Added the Maui iOS and MacCatalyst build steps for the SOD performance testing (per dotnet/performance#2075). Includes addition of runtime replacement during build, building of necessary runtime files, building of iOS and MacCatalyst, piping of the built apps through the pipeline, and the helix items for the tests.

Author:LoopedBard3
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:-

DrewScoggins
DrewScoggins reviewed Nov 1, 2021
View reviewed changes

@DrewScogginsDrewScoggins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few comments. Also do you have a link to a completed run of this?

Comment threadeng/testing/performance/ios_scenarios.proj
Comment threadeng/pipelines/coreclr/templates/perf-job.yml
Comment threadeng/pipelines/coreclr/templates/build-perf-maui-apps.yml
@LoopedBard3

LoopedBard3 commented Nov 1, 2021

Copy link
Copy Markdown
MemberAuthor

Yes, there is a completed run, DM'd it.

DrewScoggins
DrewScoggins approved these changes Nov 1, 2021
View reviewed changes

@DrewScogginsDrewScoggins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoopedBard3
LoopedBard3 merged commit 06c2dba into dotnet:mainNov 2, 2021
@ghostghost locked as resolved and limited conversation to collaborators Dec 2, 2021
@LoopedBard3
LoopedBard3 deleted the MauiiOSTestingClean branch January 20, 2022 22:08
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DrewScogginsDrewScogginsDrewScoggins approved these changes

Assignees

No one assigned

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LoopedBard3@DrewScoggins