Skip to content

[wasm] Disable failing System.Security.Cryptography tests due to http… - #61102

Merged
radical merged 2 commits into
dotnet:mainfrom
radical:disable-sec-tests
Nov 2, 2021
Merged

[wasm] Disable failing System.Security.Cryptography tests due to http…#61102
radical merged 2 commits into
dotnet:mainfrom
radical:disable-sec-tests

Conversation

@radical

@radicalradical commented Nov 2, 2021

Copy link
Copy Markdown
Member

@radicalradical added the arch-wasm WebAssembly architecture label Nov 2, 2021
@ghost

ghost commented Nov 2, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

…s://github.com//issues/61099

Author:radical
Assignees:-
Labels:

arch-wasm

Milestone:-

@bartonjs

Copy link
Copy Markdown
Member

It looks like the tests used to be disabled by a higher-level thing:

<ProjectExclusionsInclude="$(MSBuildThisFileDirectory)System.Security.Cryptography.Primitives\tests\System.Security.Cryptography.Primitives.Tests.csproj" />

Since wasm does run some tests from Algorithms, and that'll be merged in soon, it does seem like attributes are the way to go.

Comment threadsrc/libraries/System.Security.Cryptography/tests/CryptoConfigTests.cs Outdated
@radical

Copy link
Copy Markdown
MemberAuthor

Mono Product Build Linux arm64 release, and Libraries Build Linux_musl arm Release keep failing with Directory not empty.
@akoeplinger@steveisok

@steveisok

Copy link
Copy Markdown
Member

Mono Product Build Linux arm64 release, and Libraries Build Linux_musl arm Release keep failing with Directory not empty. @akoeplinger@steveisok

I believe that's a known issue b/c the workspaces do not get cleaned properly. I'd retry until it works or if you aren't patient, merge on red.

@radical
radical merged commit e815a97 into dotnet:mainNov 2, 2021
@radical
radical deleted the disable-sec-tests branch November 2, 2021 21:02
@ghostghost locked as resolved and limited conversation to collaborators Dec 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-System.Security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@radical@bartonjs@steveisok