Uh oh!
There was an error while loading. Please reload this page.
Remove dead code in jit - #61129
Merged
Merged
Conversation
ghost
commented
Nov 2, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsNoticed that the code is dead while working on an issue @dotnet/jit-contrib PTAL
|
BruceForstall
approved these changes
Nov 2, 2021
BruceForstall
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I presume no asmdiffs?
echesakov
commented
Nov 3, 2021
ContributorAuthor
I will double check this before merging |
echesakov
commented
Nov 3, 2021
ContributorAuthor
Confirmed no diffs with spmi on all four platforms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that the code is dead while working on an issue
@dotnet/jit-contrib PTAL