Uh oh!
There was an error while loading. Please reload this page.
Add additional steps in gcc validation leg - #61241
Conversation
ghost
commented
Nov 5, 2021
Tagging subscribers to this area: @hoyosjs Issue Detailsnull
|
dc53d15 to
d433ce8Compaream11
commented
Nov 5, 2021
cc @safern, @akoeplinger, @lambdageek, perhaps this hybrid approach is not elegant in terms of code; placing non-coreclr steps in |
jkoritzinsky
commented
Nov 5, 2021
@am11 since the compiler support is wired up through the root build script, I’d suggest using the global-build-job template instead and pass in a subset argument for all the native subsets and the property to set the native compiler. That will probably be much easier to maintain over time. |
43355b3 to
83855d6CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
c54ebe1 to
22542c5CompareI am keeping the step in coreclr script for now as it is a minimal change. We have similar steps in that file.
Probably, but lets do the refactoring in a separate PR. |
safern
left a comment
There was a problem hiding this comment.
I think we should use the global-build-job template as @jkoritzinsky suggested, it will be cleaner and easier to maintain long term.
Before:

After:
