Skip to content

Don't create a COM weak reference if the object is an aggregated COMWrappers RCW. - #61267

Merged
jkoritzinsky merged 3 commits into
dotnet:mainfrom
jkoritzinsky:no-weakref-agg
Nov 6, 2021
Merged

Don't create a COM weak reference if the object is an aggregated COMWrappers RCW.#61267
jkoritzinsky merged 3 commits into
dotnet:mainfrom
jkoritzinsky:no-weakref-agg

Conversation

@jkoritzinsky

@jkoritzinskyjkoritzinsky commented Nov 5, 2021•
edited by AaronRobinsonMSFT
Loading

Copy link
Copy Markdown
Member

This prevents us from trying to re-create a managed object that is a user-defined object deriving from an RCW type from a COM IWeakReference (which fails).

The included test crashes on main with an AV and passes with the changes in this PR.

Fixesmicrosoft/CsWinRT#1025

@jkoritzinskyjkoritzinsky added this to the 7.0.0 milestone Nov 5, 2021
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Nov 5, 2021
View reviewed changes
Comment threadsrc/coreclr/vm/interoplibinterface_comwrappers.cpp Outdated
Comment threadsrc/coreclr/vm/interoplibinterface_comwrappers.cpp Outdated
Comment threadsrc/tests/Interop/COM/ComWrappers/WeakReference/WeakReferenceNative.cpp
Comment threadsrc/tests/Interop/COM/ComWrappers/WeakReference/WeakReferenceTest.cs Outdated
jkoritzinsky
jkoritzinsky commented Nov 5, 2021
View reviewed changes
Comment threadsrc/coreclr/vm/interoplibinterface_comwrappers.cpp Outdated
jkoritzinsky
jkoritzinsky commented Nov 5, 2021
View reviewed changes
Comment threadsrc/tests/Interop/COM/ComWrappers/WeakReference/WeakReferenceTest.cs Outdated
@jkoritzinsky@AaronRobinsonMSFT
Apply suggestions from code review
2bb2b03
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@AaronRobinsonMSFT

AaronRobinsonMSFT commented Nov 6, 2021

Copy link
Copy Markdown
Member

@jkoritzinsky Let's start the port to .NET 6 ASAP.

@jkoritzinsky

jkoritzinsky commented Nov 6, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

github-actionsBot commented Nov 6, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1429642390

@github-actionsgithub-actionsBot mentioned this pull request Nov 6, 2021
Merged
@jkoritzinsky
jkoritzinsky merged commit aefb0fc into dotnet:mainNov 6, 2021
@jkoritzinsky
jkoritzinsky deleted the no-weakref-agg branch November 6, 2021 19:02
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 7, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@elinor-fungelinor-fungAwaiting requested review from elinor-fung

Assignees

No one assigned

Labels

area-Interop-coreclr

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Taking a WeakReference to a C# object that inherits a native WinRT object crashes the app.

2 participants

@jkoritzinsky@AaronRobinsonMSFT