Skip to content

[wasm][aot] Disable (again) Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests failing due to OOM - #61323

Merged
krwq merged 2 commits into
dotnet:mainfrom
krwq:revert-60701
Nov 9, 2021
Merged

[wasm][aot] Disable (again) Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests failing due to OOM#61323
krwq merged 2 commits into
dotnet:mainfrom
krwq:revert-60701

Conversation

@krwq

@krwqkrwq commented Nov 8, 2021

Copy link
Copy Markdown
Member

@krwq
krwq requested review from lewing and radicalNovember 8, 2021 17:44
@ghost

ghost commented Nov 8, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

The tests have been OOMing on almost every rolling build since this was merged.

Example rolling builds:
https://dev.azure.com/dnceng/public/_build/results?buildId=1457592&view=results
https://dev.azure.com/dnceng/public/_build/results?buildId=1457989&view=results
https://dev.azure.com/dnceng/public/_build/results?buildId=1454720&view=results

Author:krwq
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@lewing

lewing commented Nov 8, 2021

Copy link
Copy Markdown
Member

cc @marek-safar@steveisok

@krwq

krwq commented Nov 8, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

please feel free to scope this PR (or replace) as needed, I'm taking action solely based on this failing almost consistently

@steveisok
steveisok self-requested a review November 8, 2021 22:28
@radical

radical commented Nov 9, 2021

Copy link
Copy Markdown
Member

I'll push a change to restrict this to disabling the failing tests.

@radicalradical changed the title Revert "[wasm] Re-enable source generator tests failing due to OOM (#60701)[wasm][aot] Disable (again) Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests failing due to OOMNov 9, 2021
@radicalradical added the arch-wasm WebAssembly architecture label Nov 9, 2021
@ghost

ghost commented Nov 9, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The tests have been OOMing on almost every rolling build since this was merged.

Example rolling builds:
https://dev.azure.com/dnceng/public/_build/results?buildId=1457592&view=results
https://dev.azure.com/dnceng/public/_build/results?buildId=1457989&view=results
https://dev.azure.com/dnceng/public/_build/results?buildId=1454720&view=results

Author:krwq
Assignees:-
Labels:

arch-wasm, area-Infrastructure-libraries

Milestone:-

@krwqkrwq mentioned this pull request Nov 9, 2021
Closed
@krwq

krwq commented Nov 9, 2021

Copy link
Copy Markdown
MemberAuthor

Thanks @radical. I'll merge this, the failing test looks unrelated (I've filed #61359 to track this)

@krwq
krwq merged commit 2924d19 into dotnet:mainNov 9, 2021
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes
@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewing
@marek-safarmarek-safarAwaiting requested review from marek-safar
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@krwq@lewing@radical@steveisok