Skip to content

[wasm] Add task marshaling tests. - #61324

Merged
maraf merged 3 commits into
dotnet:mainfrom
maraf:wasm_task_marshal_tests
Nov 10, 2021
Merged

[wasm] Add task marshaling tests.#61324
maraf merged 3 commits into
dotnet:mainfrom
maraf:wasm_task_marshal_tests

Conversation

@maraf

@marafmaraf commented Nov 8, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Add various tests for marshaling task to JavaScript promise.

  • Sync and async.
  • Generic and non-generic.
  • Successful and failed.

These tests replace those added in the #47640.

@pavelsavara@kg Do you have some ideas for additional scenarios to test?

@maraf
[wasm] Add task marshaling tests.
207f97b
Add various tests for marshaling task to JavaScript promise.
- Sync and async.
- Generic and non-generic.
- Successful and failed.
@marafmaraf added this to the 7.0.0 milestone Nov 8, 2021
@ghost

ghost commented Nov 8, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Add various tests for marshaling task to JavaScript promise.

  • Sync and async.
  • Generic and non-generic.
  • Successful and failed.

@pavelsavara@kg Do you have some ideas for additional scenarios to test?

Author:maraf
Assignees:-
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone:7.0.0

@kg

kg commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

Looks good. I'd add a test for ValueTask and a test for ValueTask<int> - I believe they'll fail at present but it's worth documenting that through tests that assert they fail, since we might get requests to implement it later on.

@maraf
maraf marked this pull request as ready for review November 9, 2021 09:59
@marafmaraf mentioned this pull request Nov 9, 2021
Closed
@maraf
marafforce-pushed the wasm_task_marshal_tests branch from 6101d42 to 5f30ce3CompareNovember 10, 2021 07:01
@maraf

maraf commented Nov 10, 2021

Copy link
Copy Markdown
MemberAuthor

I have added the same bunch of tests for ValueTasks as for Tasks, as I'm expecting the marshaling implementation will be different. Let me know if it's ok or we don't need all of them.

@maraf
maraf merged commit e64cce6 into dotnet:mainNov 10, 2021
@maraf
maraf deleted the wasm_task_marshal_tests branch November 10, 2021 09:20
@pavelsavarapavelsavara mentioned this pull request Nov 10, 2021
Closed
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 10, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewing
@kgkgAwaiting requested review from kg
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@maraf@kg@pavelsavara