Skip to content

[release/6.0] Fix incorrect CCW decoding in GetObjectForCCW - #61341

Merged
Anipik merged 1 commit into
dotnet:release/6.0from
tommcdon:dev/tommcdon/fixccw_60
Nov 9, 2021
Merged

[release/6.0] Fix incorrect CCW decoding in GetObjectForCCW#61341
Anipik merged 1 commit into
dotnet:release/6.0from
tommcdon:dev/tommcdon/fixccw_60

Conversation

@tommcdon

Copy link
Copy Markdown
Member

Backport of #61193 to release/6.0

/cc @davmason@mikem8361@hoyosjs

Customer Impact

This issue blocks debugger API's for correctly identifying .NET 5.0+ COM wrappers.

Testing

Validated an end-to-end scenario using COM wrappers

Risk

Low. We are falling back to the old COM decoding logic if the new COM wrapper API code check does not succeed.

* Fix incorrect CCW decoding in GetObjectForCCW
* Fix linux/mac build
@ghost

ghost commented Nov 9, 2021

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@jeffschwMSFTjeffschwMSFT changed the title Fix incorrect CCW decoding in GetObjectForCCW[release/6.0] Fix incorrect CCW decoding in GetObjectForCCWNov 9, 2021
@jeffschwMSFTjeffschwMSFT added area-Diagnostics-coreclr Servicing-consider Issue for next servicing release review labels Nov 9, 2021
@ghost

ghost commented Nov 9, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #61193 to release/6.0

/cc @davmason@mikem8361@hoyosjs

Customer Impact

This issue blocks debugger API's for correctly identifying .NET 5.0+ COM wrappers.

Testing

Validated an end-to-end scenario using COM wrappers

Risk

Low. We are falling back to the old COM decoding logic if the new COM wrapper API code check does not succeed.

Author:tommcdon
Assignees:-
Labels:

Servicing-consider, area-Diagnostics-coreclr

Milestone:-

@jeffschwMSFTjeffschwMSFT added this to the 6.0.x milestone Nov 9, 2021

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Let's consider this for 6.0.x

@leecowleecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 9, 2021
@leecowleecow modified the milestones: 6.0.x, 6.0.1Nov 9, 2021
@Anipik
Anipik merged commit 13709ae into dotnet:release/6.0Nov 9, 2021
@ghostghost locked as resolved and limited conversation to collaborators Dec 10, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Diagnostics-coreclrServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tommcdon@jeffschwMSFT@mikem8361@hoyosjs@leecow@Anipik