Skip to content

Fix Array ctor integer widening and add Reflection tests - #61347

Merged
AaronRobinsonMSFT merged 16 commits into
dotnet:mainfrom
AaronRobinsonMSFT:reflection_array
Nov 11, 2021
Merged

Fix Array ctor integer widening and add Reflection tests#61347
AaronRobinsonMSFT merged 16 commits into
dotnet:mainfrom
AaronRobinsonMSFT:reflection_array

Conversation

@AaronRobinsonMSFT

@AaronRobinsonMSFTAaronRobinsonMSFT commented Nov 9, 2021•
edited
Loading

Copy link
Copy Markdown
Member

The Array ctor path via Reflection had a bug in its integer widening, so converted that to the correct path.
Add tests for Reflection Invoke where the input object[] is changed during invocation.
Remove some coreclr code in the Invoke path.

@AaronRobinsonMSFT
coreclr/
5822ef7
Remove always false IsStructRequiringStackAllocRetBuf().
Extract the conversion of array constructor arguments into managed.
Expose new FCall for Array ctor call.
@AaronRobinsonMSFT
libraries/
b5bdbfa
Add special case for array construction during Invoke.
@AaronRobinsonMSFT
mono/
cb13ebc
Create new icall for Array ctor call.
Create macro define for SPAN_T.
@AaronRobinsonMSFTAaronRobinsonMSFT added this to the 7.0.0 milestone Nov 9, 2021
@ghost

ghost commented Nov 9, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @buyaa-n
See info in area-owners.md if you want to be subscribed.

Issue Details

This pulls out some logic from coreclr and mono for special casing array construction. The primary improvement is the unboxing of objects to ints is now done in managed code and passed down to the runtime as a Span<int>.

Author:AaronRobinsonMSFT
Assignees:-
Labels:

area-System.Reflection

Milestone:7.0.0

@AaronRobinsonMSFT
mono/
de61440
Build issues.
@AaronRobinsonMSFT
AaronRobinsonMSFT marked this pull request as ready for review November 9, 2021 06:13
@vargaz

vargaz commented Nov 9, 2021

Copy link
Copy Markdown
Contributor

The mono changes look ok.

@AaronRobinsonMSFT

AaronRobinsonMSFT commented Nov 9, 2021

Copy link
Copy Markdown
MemberAuthor

/cc @steveharter@buyaa-n@elinor-fung@jkotas

jkotas
jkotas reviewed Nov 9, 2021
View reviewed changes
Comment threadsrc/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.Mono.cs Outdated
jkotas
jkotas reviewed Nov 9, 2021
View reviewed changes
Comment threadsrc/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.Mono.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs Outdated
jkotas
jkotas reviewed Nov 10, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs Outdated
@AaronRobinsonMSFT
libraries/
2a41c9d
Add tests for Reflection Binder type conversion support during Invoke.
jkotas
jkotas reviewed Nov 10, 2021
View reviewed changes
Comment threadsrc/coreclr/vm/reflectioninvocation.cpp Outdated
jkotas
jkotas reviewed Nov 10, 2021
View reviewed changes
Comment threadsrc/coreclr/vm/reflectioninvocation.cpp Outdated
@AaronRobinsonMSFT
coreclr/
f9ec4f4
Make sure integral types respect sign extension during widen operation.
Fix InvokeUtil::CreatePrimitiveValue to write destination size.
@AaronRobinsonMSFT
libraries/
f8512a5
Validate arg count prior to running static constructor.
jkotas
jkotas reviewed Nov 10, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs Outdated
@AaronRobinsonMSFT
coreclr/
27ae925
Properly widen the input by respecting endianness.
Revert changes to InvokeUtil::CreatePrimitiveValue.
@AaronRobinsonMSFT
libraries/
220a9b1
jkotas
jkotas reviewed Nov 10, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs Outdated
jkotas
jkotas reviewed Nov 10, 2021
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.CoreCLR.cs Outdated
jkotas
jkotas reviewed Nov 10, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.cs Outdated
Comment threadsrc/coreclr/vm/reflectioninvocation.cpp Outdated
jkotas
jkotas approved these changes Nov 10, 2021
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@AaronRobinsonMSFT
coreclr/
e988f81
Revert some non-impactful changes
@AaronRobinsonMSFT
libraries/
ff14814
Revert some non-impactful changes
@AaronRobinsonMSFT
mono/
74ec0ce
Revert some non-impactful changes
@AaronRobinsonMSFT
mono/
c10c7c4
Remove additional changes.
@AaronRobinsonMSFTAaronRobinsonMSFT changed the title Move some Reflection call of Array ctor into managedFix Array ctor integer widening and add Reflection testsNov 10, 2021
@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit ff82b6d into dotnet:mainNov 11, 2021
@AaronRobinsonMSFT
AaronRobinsonMSFT deleted the reflection_array branch November 11, 2021 00:07
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 11, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@marek-safarmarek-safarAwaiting requested review from marek-safar
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@vargazvargazAwaiting requested review from vargaz

Assignees

No one assigned

Labels

area-System.Reflection

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@AaronRobinsonMSFT@vargaz@jkotas