Skip to content

Fix credscan bugs release/5.0 - #61371

Merged
Anipik merged 1 commit into
dotnet:release/5.0from
aik-jahoda:jajahoda/credscanbackport5
Nov 10, 2021
Merged

Fix credscan bugs release/5.0#61371
Anipik merged 1 commit into
dotnet:release/5.0from
aik-jahoda:jajahoda/credscanbackport5

Conversation

@aik-jahoda

Copy link
Copy Markdown
Contributor

Backport of #61114 to release/5.0

@aik-jahodaaik-jahoda added the Servicing-consider Issue for next servicing release review label Nov 9, 2021
@aik-jahoda
aik-jahoda requested a review from wfurtNovember 9, 2021 15:22
@ghostghost added the area-System.Net label Nov 9, 2021
@ghost

ghost commented Nov 9, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #61114 to release/5.0

Author:aik-jahoda
Assignees:-
Labels:

Servicing-consider, area-System.Net

Milestone:-

@aik-jahodaaik-jahoda changed the title Fix credscan bugsFix credscan bugs release/5.0Nov 9, 2021
@danmoseleydanmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 9, 2021
@danmoseley

Copy link
Copy Markdown
Contributor

test changes - approved - doesn't need tactics

@runfoapprunfoappBot mentioned this pull request Nov 9, 2021
@aik-jahoda

Copy link
Copy Markdown
ContributorAuthor

The failing test are not related to this change,
There is tracking issue for the failures: https://github.com/dotnet/core-eng/issues/14682

@Anipik
Anipik merged commit ddd0a9c into dotnet:release/5.0Nov 10, 2021
aik-jahoda pushed a commit to aik-jahoda/runtime that referenced this pull request Nov 12, 2021
@aik-jahoda
aik-jahoda deleted the jajahoda/credscanbackport5 branch November 12, 2021 15:03
danmoseley pushed a commit that referenced this pull request Nov 15, 2021
@karelzkarelz added this to the 5.0.13 milestone Nov 23, 2021
@ghostghost locked as resolved and limited conversation to collaborators Dec 23, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.NetServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@aik-jahoda@danmoseley@stephentoub@karelz@Anipik