Skip to content

[wasm][debugger] Correct the endian swapping and string implementation - #61386

Merged
lewing merged 5 commits into
dotnet:mainfrom
lewing:fix-sdb-formatting
Nov 10, 2021
Merged

[wasm][debugger] Correct the endian swapping and string implementation#61386
lewing merged 5 commits into
dotnet:mainfrom
lewing:fix-sdb-formatting

Conversation

@lewing

@lewinglewing commented Nov 9, 2021

Copy link
Copy Markdown
Member

A limited change fix WriteString and only byte swap when needed.

@ghostghost added the area-Debugger-mono label Nov 9, 2021
@lewing
lewing requested a review from thaystgNovember 9, 2021 23:26
@ghost

ghost commented Nov 9, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:lewing
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@lewinglewing changed the title Correct the endian swapping and string implementation[wasm][debugger] Correct the endian swapping and string implementationNov 9, 2021
@lewinglewing added the arch-wasm WebAssembly architecture label Nov 9, 2021
@ghost

ghost commented Nov 9, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:lewing
Assignees:-
Labels:

arch-wasm, area-Debugger-mono

Milestone:-

@lewing
lewing requested a review from radicalNovember 9, 2021 23:27
@lewing
lewing marked this pull request as ready for review November 10, 2021 02:09
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs Outdated
@ghostghost locked as resolved and limited conversation to collaborators Dec 10, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lewing@radical@marek-safar@thaystg