Skip to content

Clean up tests under Interop/PInvoke/BestFitMapping - #61390

Merged
elinor-fung merged 5 commits into
dotnet:mainfrom
elinor-fung:bestFitTest
Nov 11, 2021
Merged

Clean up tests under Interop/PInvoke/BestFitMapping#61390
elinor-fung merged 5 commits into
dotnet:mainfrom
elinor-fung:bestFitTest

Conversation

@elinor-fung

@elinor-fungelinor-fung commented Nov 10, 2021

Copy link
Copy Markdown
Member
  • Collapse a bunch of different test projects targeting BestFitMapping
  • Pull out shared code for test data and validation
  • Add test cases specifically for unmappable characters (they were previously grouped with characters that did have a best-fit mapping and were commented out for some cases)

Aside from making my eyes bleed less when I look inside that folder, this reduces the time it takes to run the tests, time to upload results, and size of the uploaded test artifact for each PR:

BeforeAfter
Number of projects in Interop/PInvoke/BestFitMapping485
Interop.PInvoke.XUnitWrapper test run (windows x64 checked)~23s~12s
Uploading files for Interop/PInvoke/BestFitMapping results~14s~1s
CoreCLRManagedTestArtifacts_AnyOS_AnyCPU_checked.zip size47.8 MB46.5 MB

@AaronRobinsonMSFT@jkoritzinsky - sorry, the diff is probably not very helpful... All the p/invoke definitions were direct copies/moved files. The existing methods for validation were nearly all the same with assorted discrepancies where some things were or were not checked, so I pulled that all out into a shared helper so that they would avoid said discrepancies without changing how/what they were validating.

@elinor-fungelinor-fung changed the title Clean up on consolidate tests under Interop/PInvoke/BestFitMappingClean up tests under Interop/PInvoke/BestFitMappingNov 10, 2021
@elinor-fung
elinor-fung marked this pull request as ready for review November 10, 2021 23:05
@elinor-fungelinor-fung added this to the 7.0.0 milestone Nov 10, 2021
@elinor-fung

Copy link
Copy Markdown
MemberAuthor

cc @trylek - this change seems like a manual version of the test grouping you and @jkoritzinsky are working on and I think it further reinforces how much value that work would bring.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@elinor-fung@jkoritzinsky@AaronRobinsonMSFT