Uh oh!
There was an error while loading. Please reload this page.
[wasm][debugger] Tie sdb agent lifetime to the ExecutionContext and simplify the api - #61392
Merged
Conversation
ghost
commented
Nov 10, 2021
Tagging subscribers to this area: @thaystg Issue Detailsnull
|
ghost
commented
Nov 10, 2021
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
lewing
commented
Nov 10, 2021
MemberAuthor
@thaystg the smaller version is smaller but... |
lewingforce-pushed
the
binary-writer
branch
4 times, most recently
from
November 11, 2021 18:07
214efa8 to
ca4de82Compareradical
reviewed
Nov 12, 2021
Uh oh!
There was an error while loading. Please reload this page.
lewing
marked this pull request as draft
November 15, 2021 20:45
lewing
marked this pull request as ready for review
November 17, 2021 17:18
thaystg
approved these changes
Nov 17, 2021
lewing
commented
Nov 17, 2021
MemberAuthor
Needs a little more work, the merge was slightly off. Working on it now |
lewing
commented
Nov 18, 2021
MemberAuthor
should be good now. |
This was referenced Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework MonoSdbHelper and tie its lifetime to the ExecutionContext to simplify session handling.