Uh oh!
There was an error while loading. Please reload this page.
Include the "TargetingPack" folder in the mobile apps. - #61432
Conversation
ghost
commented
Nov 10, 2021
Tagging subscribers to this area: |
ghost
commented
Nov 10, 2021
Tagging subscribers to this area: @directhex |
fanyang-mono
commented
Nov 10, 2021
I was wondering if you tried to run the failing test locally to validate this change? Because the CI lane for runtime tests running on mobile targets have been moved to rolling build only. |
jkoritzinsky
commented
Nov 10, 2021
I’ll queue a rolling build directly on this branch to validate it after lunch. |
fanyang-mono
commented
Nov 10, 2021
Sounds good. Thank you! |
jkoritzinsky
commented
Nov 10, 2021
Queued the CI run as a build against the branch directly, so it'll run the mobile legs too: https://dev.azure.com/dnceng/public/_build/results?buildId=1463787&view=results |
jkoritzinsky
commented
Nov 10, 2021
Looks like the test passed in CI (The failures are on other platforms or in the libraries test tree for unrelated infrastructure issues) |
jkoritzinsky
commented
Nov 11, 2021
@fanyang-mono@agocke can I get a review on this PR? None of the test failures are related to the fix (some of it looks like Helix infra bugs in the Python scripts TBH as the logs say the tests all passed). |
jkoritzinsky
commented
Nov 11, 2021
As merging is blocked since the tvOSSimulator job timed out without reporting that it failed, I'm going to rerun the failed legs to try to get a mergeable PR state. |
fanyang-mono
commented
Nov 11, 2021
LGTM |
Include the "TargetingPack" folder in the mobile app test suites.
Fixes#61322
Fixes#61299