Uh oh!
There was an error while loading. Please reload this page.
Update previous netcoreapp version to run API Compat against 6.0 ref pack - #61437
Conversation
ghost
commented
Nov 10, 2021
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsWe are still running API Compat for the ref pack against the 5.0 ref pack rather than the 6.0 one on main. Now that the 6.0 is released we can do that.
|
safern
commented
Nov 11, 2021
It seems like we are hitting some package validation now that the baseline versions changed. I will look into them and see why. |
fa0944c to
1354b39CompareUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
I need to check these runtime net6.0 assets vs lib assets.
There was a problem hiding this comment.
Ok, so I was able to figure these out. The package doesn't have a ref folder, and this is comparing runtimes/* as the contract, VS the ridless lib (the compile asset), and it seems like the ref is not exposing these APIs. It seems like that is by design. As we even have this: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Data.Odbc/src/MatchingRefApiCompatBaseline.txt
ericstj
left a comment
There was a problem hiding this comment.
A couple look like real failures due to TFMs being removed.
Do we have a way to suppress the removed TFMs and avoid any member-specific noise about them, while still getting coverage for newer TFMs?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
safern
commented
Nov 22, 2021
Not yet, this is what I was mentioning here: #61437 (comment) We need a way to specify tmfs to ignore via an item or something like that. |
safern
commented
Nov 30, 2021
@ericstj I've replied to your feedback, could you take another look to get this unblocked? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
joperezr
left a comment
There was a problem hiding this comment.
Changes look good in general. It would be good to investigate those new ODBC ones as I wouldn't expect those either. Also, a NIT, but it might be worth adding a comment on all of the suppressions that are expected due to a drop of a TFM from the current package, that is what we did before 6.0 shipped so we should probably do that as well in this PR.
ericstj
left a comment
There was a problem hiding this comment.
So long as we're certain those suppressions aren't real issues that will be hit for supported frameworks I'm OK with this.
1354b39 to
099c709Comparesafern
commented
Dec 3, 2021
I've validated the diffs and they all make sense. |
We are still running API Compat for the ref pack against the 5.0 ref pack rather than the 6.0 one on main. Now that the 6.0 is released we can do that.