Uh oh!
There was an error while loading. Please reload this page.
Handle empty string parameter value in MetadataLoadContext - #61457
Merged
Conversation
ghost
commented
Nov 11, 2021
Tagging subscribers to this area: @buyaa-n Issue DetailsFixes #57238. Also add test for
|
buyaa-n
reviewed
Nov 15, 2021
| public void Foo4(short s = -34) { } | ||
| public void Foo5(decimal d = 1234m) { } | ||
| public void Foo6([DateTimeConstant(ticks: 8736726782)] DateTime dt) { } | ||
| public void Foo7(string s1 = "foo", string s2 = "") { } |
Contributor
There was a problem hiding this comment.
NIT: maybe add a test case for null default?
Suggested change
| publicvoidFoo7(strings1="foo",strings2=""){} | |
| publicvoidFoo7(strings1="foo",strings2="",strings3=null){} |
buyaa-n
approved these changes
Nov 15, 2021
buyaa-n
left a comment
Contributor
There was a problem hiding this comment.
Left and NIT, overall LGTM, thanks!
steveharter
approved these changes
Nov 24, 2021
This was referenced Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#57238.
Also add test for
nullparameter default value, since that is another special case.