Skip to content

[release/6.0] Don't run the JIT formatting job in CI - #61485

Merged
safern merged 1 commit into
dotnet:release/6.0from
BruceForstall:DisableJitFormatJobInRelease6
Dec 15, 2021
Merged

[release/6.0] Don't run the JIT formatting job in CI#61485
safern merged 1 commit into
dotnet:release/6.0from
BruceForstall:DisableJitFormatJobInRelease6

Conversation

@BruceForstall

Copy link
Copy Markdown
Contributor

The format job depends on the main branch of dotnet/jitutils (which isn't
properly versioned). Avoid future changes to jitutils causing a break in
servicing by disabling the formatting job.

Note that there is very little benefit to maintaining the formatting
CI requirement in servicing anyway.

The format job depends on the `main` branch of dotnet/jitutils (which isn't
properly versioned). Avoid future changes to jitutils causing a break in
servicing by disabling the formatting job.
Note that there is very little benefit to maintaining the formatting
CI requirement in servicing anyway.
@ghostghost added the area-Infrastructure-coreclr Only use for closed issues label Nov 11, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

The format job depends on the main branch of dotnet/jitutils (which isn't
properly versioned). Avoid future changes to jitutils causing a break in
servicing by disabling the formatting job.

Note that there is very little benefit to maintaining the formatting
CI requirement in servicing anyway.

Author:BruceForstall
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:-

@BruceForstall

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib I propose to disable the JIT formatting job in the release/6.0 branch to prevent possible breaking changes later on, since the job depends on the jitutils main branch. If I get a PR signoff, I'll ask for approval.

@echesakov

Copy link
Copy Markdown
Contributor

I think it makes sense to disable the job for now.

But we also need either finish dotnet/jitutils#219 (since that was my PR - I probably should finish it) or find another way of publishing versioned jitutils artifacts.

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Given this is infra. we just need to coordinate when this can be merged.

@safern
safern merged commit b2f42fa into dotnet:release/6.0Dec 15, 2021
@BruceForstall
BruceForstall deleted the DisableJitFormatJobInRelease6 branch December 15, 2021 18:51
@ghostghost locked as resolved and limited conversation to collaborators Jan 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@BruceForstall@echesakov@jeffschwMSFT@safern