Uh oh!
There was an error while loading. Please reload this page.
Make more extensive use of lvaGetDesc() - #61494
Conversation
ghost
commented
Nov 12, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIncluding the version with a I mostly replaced Made many resulting Removed unused Simplifies code, and centralizes assert checking. Added new This deletes many
|
BruceForstall
commented
Nov 12, 2021
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Including the version with a `GenTreeLclVarCommon*` overload. I mostly replaced `&lvaTable[varNum]` and `lvaTable + varNum` expressions, leaving `lvaTable[varNum].xxx`. Made many resulting `varDsc*` const. Removed unused `lvaRefCount`. Simplifies code, and centralizes assert checking. Added new `lvaGetLclNum(LclVarDsc*)` function to map back to a varNum. This deletes many `noway_assert` in favor of the lvaGetDesc `assert`; I'm not worried about removing asserts from the Release build.
47c845f to
ccf0b25CompareBruceForstall
commented
Nov 13, 2021
Rebased/re-pushed to see if the CI will be more compliant |
BruceForstall
commented
Nov 13, 2021
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
commented
Nov 15, 2021
@dotnet/jit-contrib PTAL |
AndyAyersMS
left a comment
There was a problem hiding this comment.
LGTM.
I only skimmed the first few hundred diffs.
Including the version with a
GenTreeLclVarCommon*overload.I mostly replaced
&lvaTable[varNum]andlvaTable + varNumexpressions, leaving
lvaTable[varNum].xxx.Made many resulting
varDsc*const.Removed unused
lvaRefCount.Simplifies code, and centralizes assert checking.
Added new
lvaGetLclNum(LclVarDsc*)function to map back to a varNum.This deletes many
noway_assertin favor of the lvaGetDescassert;I'm not worried about removing asserts from the Release build.
No asm diffs