Skip to content

Add [Fact] attributes on TypeGeneratorTests - #61534

Merged
trylek merged 1 commit into
dotnet:mainfrom
trylek:FactOnTypeGeneratorTests
Nov 14, 2021
Merged

Add [Fact] attributes on TypeGeneratorTests#61534
trylek merged 1 commit into
dotnet:mainfrom
trylek:FactOnTypeGeneratorTests

Conversation

@trylek

Copy link
Copy Markdown
Member

For now there's no functional change to the behavior of the tests,
I have just copied the bits to inject from Jeremy's example in his
pending PR.

Thanks

Tomas

Contributes to: #54512

For now there's no functional change to the behavior of the tests,
I have just copied the bits to inject from Jeremy's example in his
pending PR.
Thanks
Tomas
@trylektrylek added the area-Infrastructure-coreclr Only use for closed issues label Nov 12, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

For now there's no functional change to the behavior of the tests,
I have just copied the bits to inject from Jeremy's example in his
pending PR.

Thanks

Tomas

Contributes to: #54512

Author:trylek
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:-

@trylek

Copy link
Copy Markdown
MemberAuthor

I have triggered a CoreCLR outerloop run but not the CI run as I believe all these tests are Pri1 so that they don't run in CI.

@trylek

Copy link
Copy Markdown
MemberAuthor

The arm / arm64 runs are pretty flaky these days but I have double-checked in the AzDO UI that none of the outstanding failures are related to the TypeGeneratorTests I'm modifying in this PR, merging in.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@trylek@jkoritzinsky