Uh oh!
There was an error while loading. Please reload this page.
Improve System.Speech trimmability - #61566
Conversation
by removing obvious warnings
ghost
commented
Nov 14, 2021
Tagging subscribers to this area: @danmoseley Issue Detailsby removing obvious warnings
|
ghost
commented
Nov 15, 2021
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr Issue Detailsby removing obvious warnings
|
eerhardt
left a comment
There was a problem hiding this comment.
These changes LGTM.
Improve System.Speech trimmability
System.Speech isn't enabled for trimming at all today:
And we aren't baselining its trim warnings either:
runtime/src/libraries/illink-oob.targets
Line 25 in d0a0919
If we really want to make progress on Speech trimmability, we should probably be changing those places to enable trimming and start producing warnings for this library.
danmoseley
left a comment
There was a problem hiding this comment.
thanks for the cleanup.
by removing obvious warnings