Skip to content

Improve System.Speech trimmability - #61566

Merged
danmoseley merged 1 commit into
dotnet:mainfrom
kant2002:kant/speech-trimming
Nov 15, 2021
Merged

Improve System.Speech trimmability#61566
danmoseley merged 1 commit into
dotnet:mainfrom
kant2002:kant/speech-trimming

Conversation

@kant2002

Copy link
Copy Markdown
Contributor

by removing obvious warnings

by removing obvious warnings
@ghostghost added area-System.Speech community-contribution Indicates that the PR has been added by a community member labels Nov 14, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @danmoseley
See info in area-owners.md if you want to be subscribed.

Issue Details

by removing obvious warnings

Author:kant2002
Assignees:-
Labels:

area-System.Speech

Milestone:-

@marek-safarmarek-safar added the linkable-framework Issues associated with delivering a linker friendly framework label Nov 15, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

by removing obvious warnings

Author:kant2002
Assignees:-
Labels:

linkable-framework, area-System.Speech, community-contribution

Milestone:-

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM.

Improve System.Speech trimmability

System.Speech isn't enabled for trimming at all today:

<SetIsTrimmable>false</SetIsTrimmable>

And we aren't baselining its trim warnings either:

<_OOBsToIgnoreInclude="System.Speech" />

If we really want to make progress on Speech trimmability, we should probably be changing those places to enable trimming and start producing warnings for this library.

@danmoseleydanmoseley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Speechcommunity-contributionIndicates that the PR has been added by a community memberlinkable-frameworkIssues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kant2002@danmoseley@eerhardt@marek-safar