Skip to content

[wasm] renames and cleanup before modularization - #61596

Merged
pavelsavara merged 10 commits into
dotnet:mainfrom
pavelsavara:wasm_modularization8
Nov 17, 2021
Merged

[wasm] renames and cleanup before modularization#61596
pavelsavara merged 10 commits into
dotnet:mainfrom
pavelsavara:wasm_modularization8

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Nov 15, 2021•
edited
Loading

Copy link
Copy Markdown
Member
  • rename main javaScript files to main.js and test-main.js
  • sample and test script cleanup
  • rename set_exit_code method
  • rewrite test start as async method
  • improve script loading via script element on page in test
  • use BINDING.bind_static_method instead of INTERNAL where possible
  • better .d.ts exports
  • formatted html files
  • moved dotnet IFFE out of emcc Closure compiled section and re-enabled terser() and ES2018 target.

@pavelsavarapavelsavara added the arch-wasm WebAssembly architecture label Nov 15, 2021
@pavelsavarapavelsavara added this to the 7.0.0 milestone Nov 15, 2021
@ghost

ghost commented Nov 15, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • rename main javaScript files to main.js and test-main.js
  • sample and test script cleanup
  • rename set_exit_code method
  • rewrite test start as async method
  • improve script loading via script element on page in test
  • use BINDING.bind_static_method instead of INTERNAL where possible
  • better .d.ts exports
  • formatted html files
Author:pavelsavara
Assignees:-
Labels:

arch-wasm

Milestone:7.0.0

@kg

kg commented Nov 15, 2021

Copy link
Copy Markdown
Contributor

Happy to finally rename runtime to something reasonable

@pavelsavara
- no imports from outer scope
304a8b6
- move dotnet to -extern-pre-js
- re-enable JS minification
- rename main javaScript files to main.js and test-main.js
- sample and test script cleanup
- rename set_exit_code method
- rewrite test start as async method
- improve script loading via script element on page in test
- use BINDING.bind_static_method instead of INTERNAL where possible
- better .d.ts exports
- formatted html files
@pavelsavara
pavelsavara marked this pull request as ready for review November 16, 2021 06:12
@pavelsavara

pavelsavara commented Nov 16, 2021

Copy link
Copy Markdown
MemberAuthor

This passed CI tests with full matrix. I also tested debugger unit tests and debugger in Blazor app manually.

kg
kg reviewed Nov 16, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/export-types.ts Outdated
kg
kg reviewed Nov 16, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/exports.ts Outdated
kg
kg reviewed Nov 16, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/startup.ts
kg
kg reviewed Nov 16, 2021
View reviewed changes
Comment threadsrc/mono/wasm/test-main.js Outdated
kg
kg approved these changes Nov 16, 2021
View reviewed changes
maraf
maraf reviewed Nov 16, 2021
View reviewed changes
Comment threadsrc/mono/wasm/test-main.js
Comment threadsrc/mono/wasm/runtime/exports.ts
@pavelsavara
feedback from@kgand@maraf
9b14f6c
- renamed modules.ts to imports.ts which makes more sense
- improved error propagation
- renamed __initializeImportsAndExports
@pavelsavara
observe exit behavior
ba2bd5d
@thaystg

thaystg commented Nov 16, 2021

Copy link
Copy Markdown
Member

Debugger tests -> passing.
Debug a Blazor App -> working.

This was referenced Nov 16, 2021
Closed
Closed
@pavelsavara
fix build
367aca3
@pavelsavara
Merge branch 'main' into wasm_modularization8
5a1cb89
# Conflicts:
#	src/mono/wasm/runtime/startup.ts
@pavelsavara
pavelsavara merged commit da0e0f7 into dotnet:mainNov 17, 2021
pavelsavara added a commit to pavelsavara/BenchmarkDotNet that referenced this pull request Nov 19, 2021
@pavelsavara
fix perf after renames indotnet/runtime#61596
f80983b
@pavelsavarapavelsavara mentioned this pull request Nov 19, 2021
Merged
adamsitnik pushed a commit to dotnet/BenchmarkDotNet that referenced this pull request Nov 19, 2021
@pavelsavara
[wasm] fix perf after test renames (#1846)
db0a88a
* fix perf after renames in dotnet/runtime#61596
@pavelsavara
pavelsavara deleted the wasm_modularization8 branch November 20, 2021 19:38
@AndyAyersMSAndyAyersMS mentioned this pull request Nov 22, 2021
Closed
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 21, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marafmarafmaraf left review comments
@radekdoulikradekdoulikAwaiting requested review from radekdoulik
@thaystgthaystgAwaiting requested review from thaystg
@marek-safarmarek-safarAwaiting requested review from marek-safar
+1 more reviewer
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-mono

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelsavara@kg@thaystg@maraf