Skip to content

Add a JsonWriterOptions.MaxDepth property - #61608

Merged
eiriktsarpalis merged 3 commits into
dotnet:mainfrom
eiriktsarpalis:feature/jsonwriteroptions-maxdepth
Nov 22, 2021
Merged

Add a JsonWriterOptions.MaxDepth property#61608
eiriktsarpalis merged 3 commits into
dotnet:mainfrom
eiriktsarpalis:feature/jsonwriteroptions-maxdepth

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Nov 15, 2021

Copy link
Copy Markdown
Member

Add a MaxDepth property to JsonWriterOptions and ensures that JsonSerializerOptions.MaxDepth flows to Utf8JsonWriter in serialization.

Fix#44947.

@eiriktsarpaliseiriktsarpalis added this to the 7.0.0 milestone Nov 15, 2021
@eiriktsarpaliseiriktsarpalis self-assigned this Nov 15, 2021
@ghost

ghost commented Nov 15, 2021

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Nov 15, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

Add a MaxDepth property to JsonWriterOptions and ensures that JsonSerializerOptions.MaxDepth flows to Utf8JsonWriter in serialization.

Fix #44947.

Author:eiriktsarpalis
Assignees:eiriktsarpalis
Labels:

area-System.Text.Json

Milestone:7.0.0

steveharter
steveharter reviewed Nov 16, 2021
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.cs
@eiriktsarpalis
eiriktsarpalis merged commit 4892e4f into dotnet:mainNov 22, 2021
eiriktsarpalis added a commit to eiriktsarpalis/runtime that referenced this pull request Nov 23, 2021
@eiriktsarpalis
Incorporate changes fromdotnet#61608
791ec4e
eiriktsarpalis added a commit that referenced this pull request Nov 23, 2021
@eiriktsarpalis
[System.Text.Json] Move inline throw statements toThrowHelper(#61746
56b5df4
)
* Replace occurrences of inlined throws with ThrowHelper calls
* remove NoInlining from ThrowHelpers.Throw* methods
* address feedback
* remove NoInlining attribute from local throw method
* Incorporate changes from #61608
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 23, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krwqkrwqAwaiting requested review from krwq
@layomialayomiaAwaiting requested review from layomia
1 more reviewer
@steveharterstevehartersteveharter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.Jsonnew-api-needs-documentation

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Add MaxDepth to JsonWriterOptions

2 participants

@eiriktsarpalis@steveharter