Uh oh!
There was an error while loading. Please reload this page.
Restrict GITHUB_TOKEN in markdownlint action - #61622
Merged
Merged
Conversation
Currently, Actions in the dotnet/runtime repository have read/write access by default, unless their permissions have been explicitly declared. The markdownlint workflow can be restricted from all access except the repository contents. This limits what the 3rd party `markdownlint-cli` npm package can do which is installed as part of the workflow.
ghost
commented
Nov 15, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
commented
Nov 15, 2021
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThe markdownlint workflow can be restricted from all access except the repository contents. This limits what the 3rd party
|
mmitche
approved these changes
Nov 15, 2021
hoyosjs
approved these changes
Nov 15, 2021
vcsjones
commented
Nov 15, 2021
MemberAuthor
I tested this in a separate repository with the same workflow files, so, I think this is good to merge. |
This was referenced Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The markdownlint workflow can be restricted from all access except the repository contents. This limits what the 3rd party
markdownlint-clinpm package can do which is installed as part of the workflow.