Add [Fact] attributes to all remaining ilproj tests

[trylek]

No description provided.

[ghost]

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	trylek
Assignees:	-
Labels:	area-Infrastructure-coreclr
Milestone:	-

[BruceForstall]

If we ever revise the publickeytoken/version of xunit.core, it's going to be a tremendous pain. Do we even need to specify those? It looks like there is no version specified for System.Console, System.Runtime, or mscorlib in these IL tests.

[trylek]

@jkoritzinsky, can you please comment? I basically took what you have in the POC PR but I'm all for reducing longer-term maintenance pain.

[jkoritzinsky]

I'll go validate whether or not we need the version and public key token info for the test to be runnable and circle back here.

[jkoritzinsky]

So fun discovery: Since we never actually use the reflection APIs to look up the attribute, the runtime never even tries to resolve the reference. If we wanted to, we could use whatever assembly name we wanted here as it's never validated at any point. In any case, based on how mscorlib is resolved by the runtime without the version or public key token, I think we can remove them for the xunit.core reference as well and the loading will work if any of the IL tests move to use any other Xunit APIs.

[trylek]

Great to know, I'll update this PR by removing the assembly details and I'll prepare another PR removing them from those ilproj tests I have already switched over, thanks Jeremy for verifying!

[trylek]

Merging in with one unrelated failure in library tests that are unaffected by my change.