Skip to content

[mono][aot] Fix the inclusion of generic instances when doing profile… - #61627

Merged
vargaz merged 1 commit into
dotnet:mainfrom
vargaz:aot-profile
Nov 17, 2021
Merged

[mono][aot] Fix the inclusion of generic instances when doing profile…#61627
vargaz merged 1 commit into
dotnet:mainfrom
vargaz:aot-profile

Conversation

@vargaz

@vargazvargaz commented Nov 15, 2021

Copy link
Copy Markdown
Contributor

…d AOT.

If a profile contained a method like List:.ctor () and the
'profile-only' option was used, the fully shared version of the method
needs to be added to the aot image.

@vargaz
[mono][aot] Fix the inclusion of generic instances when doing profile…
a824b30
…d AOT.
If a profile contained a method like List<AnInst>:.ctor () and the
'profile-only' option was used, the fully shared version of the method
needs to be added to the aot image.
lambdageek
lambdageek approved these changes Nov 16, 2021
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-compiler.c
Comment threadsrc/mono/mono/mini/aot-compiler.c
@vargaz
vargaz merged commit 0666ebc into dotnet:mainNov 17, 2021
@vargaz
vargaz deleted the aot-profile branch November 17, 2021 07:11
@AndyAyersMSAndyAyersMS mentioned this pull request Nov 22, 2021
Closed
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 17, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@imhameedimhameedAwaiting requested review from imhameed
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT

Assignees

No one assigned

Labels

area-Codegen-AOT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vargaz@lambdageek