Uh oh!
There was an error while loading. Please reload this page.
Only run JIT formatting job if there are JIT changes - #61632
Merged
BruceForstall merged 1 commit intoNov 16, 2021
Conversation
ghost
commented
Nov 15, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
BruceForstall
commented
Nov 15, 2021
ContributorAuthor
@dotnet/jit-contrib |
| - '*' | ||
| - subset: coreclr_jit | ||
| include: | ||
| - src/coreclr/jit/* |
ContributorAuthor
There was a problem hiding this comment.
I presume this means all files in the jit directory and all subdirectories of the jit directory?
Member
There was a problem hiding this comment.
Yes. If you want to know more about how this works, here is the summary of how it works:
runtime/eng/pipelines/evaluate-changed-paths.sh
Lines 2 to 17 in d471a03
And this is the logic that takes care of that:
runtime/eng/pipelines/evaluate-changed-paths.sh
Lines 132 to 183 in d471a03
kunalspathak
approved these changes
Nov 15, 2021
danmoseley
commented
Nov 15, 2021
Contributor
This looks right to me but someone like @safern should OK it. |
safern
approved these changes
Nov 15, 2021
This was referenced Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.