Uh oh!
There was an error while loading. Please reload this page.
[wasm] Add a new supported signature for pinvokes - #61667
Conversation
ghost
commented
Nov 16, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
commented
Nov 16, 2021
lewing
commented
Nov 16, 2021
Yeah this is on my list. I'll open an issue to make it clear. |
SamMonoRT
commented
Nov 17, 2021
cc @lewing - the issue is marked with 6.0.x milestone. |
TheSpydog
commented
Nov 17, 2021
Since filing the original issue (#61156) I've discovered several more unsupported pinvoke signatures in our codebase. I generated the other signatures required for our assembly with wasm-tuner, so should I submit them as a separate PR? Or should I hold off on that in favor of the upcoming change to create the signature set at compile time? |
@TheSpydog I think we should include them as part of this PR. Could you please share the cookies/hashes for these signatures ? |
TheSpydog
commented
Nov 19, 2021
Sure, the additional missing signature hashes are as follows: |
c3967e2 to
009d7c6Comparelewing
commented
Dec 15, 2021
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ideally we would want to compute this set of signatures at compile time.
Fixes#61156