Uh oh!
There was an error while loading. Please reload this page.
Remove XUnit reference metadata from tests I switched over last week - #61691
Merged
Merged
Conversation
During code review of my latest PR Bruce raised the concern that hard-coding public key values and version ID for the xunit.core reference will cause enormous maintenance pain if we decide to upgrade to a newer version of the module in the future. As Jeremy verified that the metadata is not really needed, I'm deleting it from all tests I switched over last week. Thanks Tomas
ghost
commented
Nov 16, 2021
Tagging subscribers to this area: @hoyosjs Issue DetailsDuring code review of my latest PR Bruce raised the concern that Thanks Tomas Contributes to: #54512
|
jkoritzinsky
approved these changes
Nov 16, 2021
trylek
commented
Nov 17, 2021
MemberAuthor
Merging in, the mono failures are unrelated as the failing tests are under the |
This was referenced Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During code review of my latest PR Bruce raised the concern that
hard-coding public key values and version ID for the xunit.core
reference will cause enormous maintenance pain if we decide to
upgrade to a newer version of the module in the future. As Jeremy
verified that the metadata is not really needed, I'm deleting it
from all tests I switched over last week.
Thanks
Tomas
Contributes to: #54512