Uh oh!
There was an error while loading. Please reload this page.
Default BuildTargetFramework to NetCoreAppCurrent for GenerateReferenceAssemblySource - #61760
Merged
Conversation
ghost
commented
Nov 18, 2021
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue Detailscc: @BrennanConroy
|
BrennanConroy
approved these changes
Nov 18, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
generated for the best tfm rather than all.
safernforce-pushed
the
safern/genrefsourcedoc
branch
from
November 20, 2021 01:18
fc073f7 to
849a8abCompareMemberAuthor
@eerhard I've defaulted BuildTargetFramework when running the target to netcoreappcurrent. PTAL. |
ericstj
approved these changes
Nov 22, 2021
This was referenced Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we would run GenerateReferenceAssembly source for all tfms, leading to an ordering issue as the last tfm that is run for wins and that's not essentially what we want. Let's default the BuildTargetFramework on the outer target to netcoreappcurrent so that we by default generate the ref for that, and if someone wants another tfm, they can specify their
BuildTargetFramework.cc: @BrennanConroy