Add JitDisasmWithDebugInfo

[jakobbotsch]

• Add COMPlus_JitDisasmWithDebugInfo. When set and in verbose/disasm mode,
  JIT will display inline comments with debug information before the
  instructions that debug info applies to. Change superpmi with
  --debuginfo to use this mode. Also small change to dotnet-pgo flow graph
  dump to write offsets in the same format.

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Add COMPlus_JitDisasmWithDebugInfo. When set and in verbose/disasm
  mode, JIT will display inline comments containing debug information
  before instructions marking that debug info. Change superpmi with
  --debuginfo to use this mode. Also small change to dotnet-pgo flow
  graph dump to write offsets in the same format.

• Refactor CMake build for JIT to include headers and arch-specific
  headers in the same way as sources. This makes arch-specific headers
  appear in the correct standalone jit (clrjit_universel_arm64_x64 etc.)
  projects. Refactor some of the declarations in the emitter.

Author:	jakobbotsch
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[jakobbotsch]

Example of how this looks with superpmi asmdiffs --debuginfo for an upcoming change that fixes some cases where we lose debug info:

diff --git "a/C:\\dev\\dotnet\\spmi\\asm.benchmarks.run.windows.x64.checked.3\\base\\634.dasm" "b/C:\\dev\\dotnet\\spmi\\asm.benchmarks.run.windows.x64.checked.3\\diff\\634.dasm"
index e985c6e..675ed01 100644
--- "a/C:\\dev\\dotnet\\spmi\\asm.benchmarks.run.windows.x64.checked.3\\base\\634.dasm"+++ "b/C:\\dev\\dotnet\\spmi\\asm.benchmarks.run.windows.x64.checked.3\\diff\\634.dasm"@@ -25,6 +25,7 @@ G_M63213_IG01: ; gcrefRegs=00000000 {}, byrefRegs=00000000 {}, byref, nog
; gcrRegs +[rsi]
;; bbWeight=1 PerfScore 4.50
G_M63213_IG02: ; gcrefRegs=00000040 {rsi}, byrefRegs=00000000 {}, byref
+ ; INLRT @ 0x000[E-]
mov edi, dword ptr [rsi+40]
sub edi, dword ptr [rsi+48]
movsxd rdx, edi
@@ -33,6 +34,7 @@ G_M63213_IG02: ; gcrefRegs=00000040 {rsi}, byrefRegs=00000000 {}, byref
; gcr arg pop 0
mov rbx, rax
; gcrRegs +[rbx]
+ ; INL02 @ 0x000[E-] <- INLRT @ 0x00C[E-]
mov r9d, edi
mov rcx, rsi
; gcrRegs +[rcx]
@@ -42,6 +44,7 @@ G_M63213_IG02: ; gcrefRegs=00000040 {rsi}, byrefRegs=00000000 {}, byref
call System.Collections.Generic.HashSet`1[__Canon][System.__Canon]:CopyTo()
; gcrRegs -[rax rcx rdx rsi]
; gcr arg pop 0
+ ; INLRT @ 0x013[E-]
mov rax, rbx
; gcrRegs +[rax]
;; bbWeight=1 PerfScore 8.75
@@ -70,8 +73,9 @@ Unwind Info:
CodeOffset: 0x03 UnwindOp: UWOP_PUSH_NONVOL (0) OpInfo: rbx (3)
CodeOffset: 0x02 UnwindOp: UWOP_PUSH_NONVOL (0) OpInfo: rsi (6)
CodeOffset: 0x01 UnwindOp: UWOP_PUSH_NONVOL (0) OpInfo: rdi (7)
-IP mapping count : 4+IP mapping count : 5
IL offs PROLOG : 0x00000000 ( STACK_EMPTY )
+IL offs 0x0000 : 0x0000000F ( STACK_EMPTY )
IL offs 0x000C : 0x00000020 ( STACK_EMPTY )
IL offs 0x0013 : 0x00000031 ( STACK_EMPTY )
IL offs EPILOG : 0x00000034 ( STACK_EMPTY )

cc @dotnet/jit-contrib

[jakobbotsch]

I'll split out the CMake change from this PR.

EDIT: Opened #61800 for that.

[BruceForstall]

LGTM