Skip to content

[wasm] workaround test results corruption - #61841

Merged
pavelsavara merged 9 commits into
dotnet:mainfrom
pavelsavara:wasm_test_results_corruption
Nov 23, 2021
Merged

[wasm] workaround test results corruption#61841
pavelsavara merged 9 commits into
dotnet:mainfrom
pavelsavara:wasm_test_results_corruption

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Nov 19, 2021

Copy link
Copy Markdown
Member

Fixes#61749

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

In hope that it fixes or surfaces more the issue #61749

Author:pavelsavara
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@pavelsavarapavelsavara added the arch-wasm WebAssembly architecture label Nov 19, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In hope that it fixes or surfaces more the issue #61749

Author:pavelsavara
Assignees:-
Labels:

arch-wasm, area-Infrastructure-libraries

Milestone:-

@marafmaraf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞

@pavelsavarapavelsavara added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 19, 2021

@lewinglewing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once the test changes are reverted

Comment threadeng/pipelines/runtime.yml Outdated
@pavelsavara

Copy link
Copy Markdown
MemberAuthor

Error while saving testResults.xml System.Xml.XmlException: Data at the root level is invalid. Line 2, position 1.

@pavelsavara

Copy link
Copy Markdown
MemberAuthor

Work in progress here dotnet/xharness#771

@pavelsavara

Copy link
Copy Markdown
MemberAuthor

Will need new nuget binaries from dotnet/xharness#771

@pavelsavara

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-manual

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-manual

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
pavelsavara marked this pull request as ready for review November 22, 2021 17:37
@pavelsavarapavelsavara removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 22, 2021
@pavelsavara

Copy link
Copy Markdown
MemberAuthor

@radical@maraf@lewing I think this fixes XML corruption problem for WASM.
There are few failed tests for WASM, but I believe they have other causes, Ankit could you please confirm I got it right ?

@premun I know that you are working on bumping all other dependencies too in #61668 shall we wait for that instead of merging it here ?

@premun

Copy link
Copy Markdown
Member

Please merge it here

@radical

Copy link
Copy Markdown
Member

You can ignore the Wasm/Windows/AOT tests.

Comment threadsrc/mono/wasm/test-main.js Outdated
@radical

Copy link
Copy Markdown
Member

You can ignore the Wasm/Windows/WBT tests also. I am disabling them in #61937 .

Comment threadsrc/mono/wasm/test-main.js Outdated
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm] Malformed testResults.xml causing CI test runs to fail

5 participants

@pavelsavara@premun@radical@lewing@maraf