Uh oh!
There was an error while loading. Please reload this page.
Add NetCoreAppCurrent configurations to Microsoft.Extensions libraries - #61867
Conversation
This makes all Extensions projects consistent in which TFMs they target. This way we don't need to add new TFMs during development of a new feature. Fixdotnet#54012
ghost
commented
Nov 20, 2021
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
commented
Nov 20, 2021
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsThis makes all Extensions projects consistent in which TFMs they target. This way we don't need to add new TFMs during development of a new feature. Fix #54012 It is probably easiest to review the commits separately.
@buyaa-n - can you review the supported platforms work I did in the 2nd commit? (note that I ran into dotnet/roslyn-analyzers#4282 and worked around it with redundant Debug.Asserts).
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| if ((_activityTrackingOption & ActivityTrackingOptions.Baggage) != 0) | ||
| { | ||
| // Only access activity.Baggage as every call leads to an allocation | ||
| IEnumerable<KeyValuePair<string, string?>> baggage = activity.Baggage; |
There was a problem hiding this comment.
why we removed the nullability here? Activity.Baggage is already defined as nullable I guess
There was a problem hiding this comment.
Because the rest of the library doesn't have nullability enabled. And since we don't, the compiler is warning. These changes will likely be undone when we enable nullability in this library.
Uh oh!
There was an error while loading. Please reload this page.
buyaa-n
commented
Nov 22, 2021
LGTM, thanks! |
This makes all Extensions projects consistent in which TFMs they target. This way we don't need to add new TFMs during development of a new feature.
Fix#54012
It is probably easiest to review the commits separately.
@buyaa-n - can you review the supported platforms work I did in the 2nd commit? (note that I ran into dotnet/roslyn-analyzers#4282 and worked around it with redundant Debug.Asserts).