Uh oh!
There was an error while loading. Please reload this page.
[TODO-List-Cleanup] Delete the quirks - #61876
Merged
echesakov merged 2 commits intoDec 16, 2021
Merged
Conversation
ghost
commented
Nov 20, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThese were left in only to get to a clean zero-diffs change. Delete them. Small diffs are expected (last time I diffed this, we got some CSEs on ARM64 and some test-only changes due to operand swapping affecting RA).
|
SingleAccretion
marked this pull request as ready for review
November 20, 2021 21:18
SingleAccretion
commented
Nov 20, 2021
ContributorAuthor
@dotnet/jit-contrib |
JulieLeeMSFT
commented
Nov 22, 2021
Member
@echesakov PTAL. |
SingleAccretionforce-pushed
the
TODO-List-Cleanup-Delete-Quirks
branch
from
December 1, 2021 12:14
026c564 to
289a493CompareSingleAccretionforce-pushed
the
TODO-List-Cleanup-Delete-Quirks
branch
from
December 10, 2021 18:00
289a493 to
15e68d2Compareechesakov
approved these changes
Dec 16, 2021
echesakov
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Sorry for the delayed review - somehow this change fell off my radar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were left in only to get to a clean zero-diff change. Delete them.
Small diffs, as expected, mostly improvements due to new CSEs. A few small regressions due to new copies being propagated, but not in a way that ultimately pays off.