Uh oh!
There was an error while loading. Please reload this page.
[TODO-List-Cleanup] Delete dead code from InferStructOpSizeAlign - #61880
Merged
BruceForstall merged 1 commit intoNov 24, 2021
Merged
Conversation
The method's only caller is InferOpSizeAlign. That is in turn only used in LCL_FLD stress, which only looks at locals with non-struct types. And "fgInitArgInfo", which only allows 3 nodes with TYP_STRUCT: OBJ, LCL_VAR and MKREFANY. Thus, this code is dead. Not surprising, considering it was looking for the old GT_COPYBLK representation.
ghost
commented
Nov 20, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThe method's only caller is That is in turn only used in And Thus, this code is dead. Not surprising, considering it was looking for the old
|
InferStructOpSizeAlignInferStructOpSizeAlignSingleAccretion
marked this pull request as ready for review
November 20, 2021 21:18
SingleAccretion
commented
Nov 20, 2021
ContributorAuthor
@dotnet/jit-contrib |
JulieLeeMSFT
commented
Nov 22, 2021
Member
@BruceForstall PTAL. |
BruceForstall
approved these changes
Nov 24, 2021
BruceForstall
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
This was referenced Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method's only caller is
InferOpSizeAlign.That is in turn only used in
LCL_FLDstress, which only looks at locals with non-struct types.And
fgInitArgInfo, which only allows 3 nodes withTYP_STRUCT:OBJ,LCL_VARandMKREFANY.Thus, this code is dead. Not surprising, considering it was looking for the old
GT_COPYBLKrepresentation.No diffs.