Uh oh!
There was an error while loading. Please reload this page.
Update hash of the new CSE when resizing - #61984
Merged
jakobbotsch merged 1 commit intoNov 29, 2021
Merged
Conversation
The CSE logic maintains a custom hashtable implementation. It triggers a resize at the same time as adding a new CSE, but forgets the hash of the new CSE needs to be updated from its pre-resize value. Failing to do so can lead to losing some CSEs, though not in a correctness-impacting way.
ghost
commented
Nov 23, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThe CSE logic maintains a custom hashtable implementation. It triggers a resize at the same time as adding a new CSE, but forgets the hash of the new CSE needs to be updated from its pre-resize value. Failing to do so can lead to losing some CSEs, though not in a correctness-impacting way, I believe. This was causing spurious diffs over at #61933. We are expecting small diffs due to some new CSEs.
|
SingleAccretion
marked this pull request as ready for review
November 24, 2021 09:00
SingleAccretion
commented
Nov 24, 2021
ContributorAuthor
@dotnet/jit-contrib |
This was referenced Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSE logic maintains a custom hashtable implementation.
It triggers a resize at the same time as adding a new CSE, but forgets the hash of the new CSE needs to be updated from its pre-resize value. Failing to do so can lead to losing some CSEs, though not in a correctness-impacting way, I believe.
This was causing spurious diffs over at #61933.
We are expecting small diffs due to some new CSEs.
For example, here is one Win-x64 diff
We discover the CSE "earlier":
Full diffs.