Skip to content

[wasm][debugger] Add Browsable Attribute support. - #62045

Merged
ilonatommy merged 52 commits into
dotnet:mainfrom
ilonatommy:debugger-browse-attribute
Jan 3, 2022
Merged

[wasm][debugger] Add Browsable Attribute support.#62045
ilonatommy merged 52 commits into
dotnet:mainfrom
ilonatommy:debugger-browse-attribute

Conversation

@ilonatommy

@ilonatommyilonatommy commented Nov 25, 2021•
edited by thaystg
Loading

Copy link
Copy Markdown
Member

Task: add DebuggerBrowsableAttribute feature to the wasm debugger.

Expected behavior: doc.

  • Changing expected behavior for MulticastDelegateTest - in Console Application EventHandler is Browsable.Never by default so we should not expect it to be visible in the debug window.

@ilonatommyilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Nov 25, 2021
@ilonatommyilonatommy self-assigned this Nov 25, 2021
@ghost

ghost commented Nov 25, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Task: add DebuggerBrowsableArrtibute feature to the wasm debugger.

Expected behavior: doc.

Author:ilonatommy
Assignees:ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone:-

@ilonatommy
ilonatommy marked this pull request as ready for review December 1, 2021 16:06
@ilonatommy
ilonatommy removed the request for review from marek-safarDecember 1, 2021 16:07
radical
radical previously requested changes Dec 1, 2021
View reviewed changes

@radicalradical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review. This is looking good, just have some suggestions.

Comment threaddocs/design/mono/debugger.md Outdated
Comment threaddocs/design/mono/debugger.md Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs Outdated
@ghostghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 1, 2021
@ilonatommy@radical
Update docs/design/mono/debugger.md
973bd3a
Co-authored-by: Ankit Jain <radical@gmail.com>
@ghostghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 2, 2021
@ilonatommy
ilonatommy marked this pull request as ready for review December 21, 2021 11:39
@ilonatommy
ilonatommy requested review from thaystg and removed request for thaystgDecember 21, 2021 11:40
thaystg
thaystg reviewed Dec 22, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
thaystg
thaystg reviewed Dec 22, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
thaystg
thaystg reviewed Dec 22, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs Outdated
thaystg
thaystg reviewed Dec 22, 2021
View reviewed changes

@thaystgthaystg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file added?
image

@ilonatommyilonatommy mentioned this pull request Jan 3, 2022
Merged
7 tasks
thaystg
thaystg approved these changes Jan 3, 2022
View reviewed changes

@thaystgthaystg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilonatommy
ilonatommy merged commit 7574e03 into dotnet:mainJan 3, 2022
@ghostghost locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical left review comments
@thaystgthaystgthaystg approved these changes

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ilonatommy@thaystg@radical