Skip to content

Avoid switching GC mode in COM's HasValidTarget - #62066

Merged
jkotas merged 2 commits into
dotnet:mainfrom
am11:feature/tests/interop
Nov 26, 2021
Merged

Avoid switching GC mode in COM's HasValidTarget#62066
jkotas merged 2 commits into
dotnet:mainfrom
am11:feature/tests/interop

Conversation

@am11

@am11am11 commented Nov 26, 2021

Copy link
Copy Markdown
Member

Fixes#62063.

@ghostghost added area-Interop-coreclr community-contribution Indicates that the PR has been added by a community member labels Nov 26, 2021
@am11

am11 commented Nov 26, 2021

Copy link
Copy Markdown
MemberAuthor

cc @jkotas, can we run the gc-standalone pipeline for this PR, as it is the one where failing test was discovered? (this pipeline is failing for some time)

jkotas
jkotas reviewed Nov 26, 2021
View reviewed changes
Comment threadsrc/coreclr/vm/interoplibinterface_comwrappers.cpp Outdated
@jkotas

jkotas commented Nov 26, 2021

Copy link
Copy Markdown
Member

/azp run gc-standalone

@azure-pipelines

azure-pipelinesBot commented Nov 26, 2021

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@jkotas

jkotas commented Nov 26, 2021

Copy link
Copy Markdown
Member

can we run the gc-standalone pipeline for this PR

Triggered

jkotas
jkotas approved these changes Nov 26, 2021
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

This was referenced Nov 26, 2021
Closed
Closed
@am11

am11 commented Nov 26, 2021

Copy link
Copy Markdown
MemberAuthor

COM wrapper test is not failing anymore: https://dev.azure.com/dnceng/public/_build/results?buildId=1487089&view=ms.vss-test-web.build-test-results-tab (compared with the previous run https://dev.azure.com/dnceng/public/_build/results?buildId=1486145&view=ms.vss-test-web.build-test-results-tab).

For remaining failures, I have opened #62083 and #62084. RuntimeConfiguration test is a new one, so I reported to @AaronRobinsonMSFT directly: #61950 (comment).

@jkotas
jkotas merged commit 15649df into dotnet:mainNov 26, 2021
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 26, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes

Assignees

No one assigned

Labels

area-Interop-coreclrcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Interop ComWrappersTests failures

2 participants

@am11@jkotas