Skip to content

Sync shared code from aspnetcore - #62069

Merged
JamesNK merged 1 commit into
mainfrom
github-action/sync-aspnetcore-1637893499
Nov 26, 2021
Merged

Sync shared code from aspnetcore#62069
JamesNK merged 1 commit into
mainfrom
github-action/sync-aspnetcore-1637893499

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Nov 26, 2021

Copy link
Copy Markdown
Contributor

This PR was automatically generated to sync shared code changes from aspnetcore. Fixesdotnet/aspnetcore#18943

@github-actions
github-actionsBot requested a review from a teamNovember 26, 2021 02:25
@ghost

ghost commented Nov 26, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943

Author:github-actions[bot]
Assignees:-
Labels:

area-System.Net.Http

Milestone:-

@JamesNK

JamesNK commented Nov 26, 2021

Copy link
Copy Markdown
Member

Synced changes from fixing dotnet/aspnetcore#38604

This code is related to writing :status which SocketsHttpHandler won't use. There might be some reaction required if there is test code that writes a status.

ManickaP
ManickaP approved these changes Nov 26, 2021
View reviewed changes

@ManickaPManickaP left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

CarnaViire
CarnaViire approved these changes Nov 26, 2021
View reviewed changes

@CarnaViireCarnaViire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
No reaction is needed for tests AFAIK, because tests (for some unknown reason) use separate simplified encoders for both HPACK and QPACK -- and they don't touch files from the shared folder -- maybe that should be changed in the future.

@TratcherTratcher mentioned this pull request Nov 26, 2021
Closed
@JamesNK
JamesNK merged commit 574b2d4 into mainNov 26, 2021
@akoeplinger
akoeplinger deleted the github-action/sync-aspnetcore-1637893499 branch November 26, 2021 19:36
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 27, 2021
@karelzkarelz added this to the 7.0.0 milestone Jan 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@CarnaViireCarnaViireCarnaViire approved these changes
@ManickaPManickaPManickaP approved these changes

Assignees

No one assigned

Labels

area-System.Net.Http

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

The runtime<->aspnetcore shared src is out of sync

4 participants

@JamesNK@CarnaViire@ManickaP@karelz