Uh oh!
There was an error while loading. Please reload this page.
Delete GT_SIMD_CHK and GT_HW_INTRINSIC_CHK - #62088
Conversation
ghost
commented
Nov 26, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThe former was unused, the latter - barely used. Overall, there is no need for these to be separate opers, it just leads to unnecessary There are two commits with this change: first just mechanically the opers, leaving for back-compat places where the array checks were treated different as they were. The second commit removes the distinction as it is not a useful one. Since the bounds checks are (no longer) array-only, the remaining oper was renamed to simply
|
366dd06 to
01de691CompareSingleAccretion
commented
Nov 28, 2021
@dotnet/jit-contrib |
jakobbotsch
commented
Nov 29, 2021
Whoops, that approval was meant for #61911. 😄 |
5ac62d2 to
722f8e0CompareThe former was unused, the latter - barely used. Overall, there is no need for these to be separate opers, it just leads to unnecessary `#ifdef`s.
In loop cloning: redundant with the check for constant lengths below.
In assertion propagation: needless pessimization.
In range check: not needed. While it is not useful to search for the
array lengths from "new int[] { ... }" expressions, it is still useful
to look for assertions related to them.722f8e0 to
866b487CompareAndyAyersMS
commented
Dec 16, 2021
@echesakov are you going to review as well? |
The former was unused, the latter - barely used. Overall, there is no need for these to be separate opers, it just leads to unnecessary
#ifdefs.There are two commits with this change: first just mechanically deletes the opers, leaving for back-compat places where the array checks were treated differently. The second commit removes the distinction as it is not a useful one.
Since the bounds checks are (no longer) array-only, the remaining oper was renamed to simply
GT_BOUNDS_CHECK.Some diffs from the second commit, in particular the assertion propagation change.